Merged, I also backported it to syncevolution-0-9-branch

Best Regards,
Congwu


>-----Original Message-----
>From: Zhu, Yongsheng
>Sent: Wednesday, January 06, 2010 2:05 PM
>To: Chen, Congwu; Chen, Congwu; Ove Kaaven
>Cc: SyncEvolution
>Subject: RE: [SyncEvolution] SyncEvolution in Fremantle
>
>Ok for me. please go forward.
>
>Cheers,
>Yongsheng
>
>> -----Original Message-----
>> From: [email protected]
>> [mailto:[email protected]] On Behalf Of Chen,
>Congwu
>> Sent: Wednesday, January 06, 2010 1:25 PM
>> To: Chen, Congwu; Ove Kaaven
>> Cc: SyncEvolution
>> Subject: Re: [SyncEvolution] SyncEvolution in Fremantle
>>
>> I fixed this issue in 9aad6cee430d198d7376bdf45075f7a18ff9d25e congwu
>branch.
>> Yongsheng, please review and I will merge it later.
>>
>> Chen, Congwu wrote:
>> >On Sat, 26 Dec 2009, Ove Kaaven wrote:
>> >My comments for your reference.
>> >> > On Thu, 2009-12-24 at 08:03 +0000, Ove Kaaven wrote:
>> >> >> It can't yet be built with a buildbot, primarily because not all of its
>> >> >> build-dependencies exist in maemo-devel, cppunit in particular.
>> >> >
>> >> > This shouldn't be a hard dependency. Without cppunit, "client-test"
>> >> > can't be built, but that is not necessary during normal usage. If you
>> >> > ran into a compile problem without cppunit, then please file a bug
>> >> > report.
>> >>
>> >> src/backends/evolution/Makefile.am and src/backends/file/Makefile.am
>> >> both enforce -DENABLE_INTEGRATION_TESTS flag regardless of how the
>> >> source is configured. This doesn't seem to cause a run-time dependency,
>> >> but it definitely causes a compile-time dependency when --enable-shared
>> >> is used (not with --disable-shared, since only the *Register.cpp files
>> >> actually includes test.h). So I should go to bugzilla with that?
>> >That indeed looks like a bug. I will look at this further, thanks for your
>> >report!
>>
>> Best Regards,
>> Congwu
>> _______________________________________________
>> SyncEvolution mailing list
>> [email protected]
>> http://lists.syncevolution.org/listinfo/syncevolution
_______________________________________________
SyncEvolution mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution

Reply via email to