Hello Salvatore! I made some more small fixes as it went into master. Let me describe them here and give some tips how to avoid them:
commit a4b23538675d54e10da0544ef2f885e0cccc5168 Author: Patrick Ohly <[email protected]> Date: Thu Jun 16 19:30:22 2011 +0200 autotools: fixed "make dist" Header files must be listed explicitly in autotools. Otherwise they are not getting included in source tar balls. "make distcheck" exposes that problem. "make distcheck" is not normally necessary before submitting patches, the nightly testing will expose these issues. But if you want to be certain, run it and it'll make my life a bit easier. I have this dream about automatic integration and compile runs of proposed patches, but so far this is just a pipe dream: https://bugs.meego.com/show_bug.cgi?id=735 commit 871d55a9d392ac069de90dc70c25fa92d9122628 Author: Patrick Ohly <[email protected]> Date: Thu Jun 16 19:29:19 2011 +0200 NotificationBackendLibnotify: fixed compile problem Initializing a pointer with false is not correct. With -Wall -Werror, clang aborts. If you are not using -Wall -Werror already, you should start doing it. See the HACKING document. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
