Hello! Chris is working on reorganizing and (eventually) rewriting the syncevo-dbus-server. The first part is splitting up the large syncevo-dbus-server.cpp into more manageable pieces.
Chris, before work starts on more fundamental design changes, can you outline what you want to do and how? That's the big picture. Part of the details is coding style. It's poorly documented in the HACKING document (basically just referencing another document) and not followed consistently. I probably need to have a look at the code that you are writing to determine whether there's anything that I'd like to have done differently. One thing caught my eye: commit 581339e3b2c0a4492a4c92d765af12a9158d85f6 Author: Murray Cumming <[email protected]> Date: Wed Jun 15 11:08:43 2011 +0200 dbus-server: Do not use NULL in C++ code. NULL does not meant the same thing in C as in C++. It can lead to hard-to-debug problems. Why should NULL not be used? It can't be the (void *)0 definition as in C, but both 0 (the generic C++ null pointer) or g++'s __null [1] should be fine. I personally like to use NULL because it makes C and C++ code more consistent and as additional indicator that a type is a pointer. [1] http://gcc.gnu.org/onlinedocs/libstdc++/manual/bk01pt02ch04s03.html -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
