On Fr, 2011-07-22 at 15:32 +0100, Valluri, Amarnath wrote: > Hi Patrick, > > I did the needed changes to resolve : > https://bugs.meego.com/show_bug.cgi?id=11251 > > Can you please review. Here is the commit : > https://meego.gitorious.org/meego-middleware/syncevolution/commit/1d318a76bfbca2d5123564aa530899bb6d9dc759
In the new VJOURNAL sub-profile your list VALARM. According to http://www.ietf.org/rfc/rfc2445.txt "4.6.3 Journal Component", a VJOURNAL must not contain VALARMs. Please double-check the profile against the RFC. + <datatype name="journal-plain" basetype="text"> + <use profile="journal"/> + <typestring>text/plain</typestring> + <versionstring>1.0</versionstring> + <incomingscript><![CDATA[ + CALTYPE=2; //inform to script that, treat this as JOURNAL + $VCALENDAR_INCOMING_SCRIPT + ]]></incomingscript> + </datatype> The datatypes note10 and note11 exist for one and only one reason: there was some confusion in the SyncML community whether plain/text has mime version 1.0 or 1.1. Therefore Synthesis offers both and treats them internally exactly alike. We must replicate that with "journal-plain-10" and "journal-plain-11". Other than that it all looks good. Please revise it by adding fixes for the issues mentioned above (don't squash, I'll do that when merging). -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ SyncEvolution mailing list [email protected] http://lists.syncevolution.org/listinfo/syncevolution
