On Mi, 2011-08-31 at 07:35 +0100, Andy Gould wrote:
> On 30/08/11 16:05, Patrick Ohly wrote:
> >
> > Does't that have the effect that time zone information where the offset
> > is zero for parts of of the year will be dropped if the event start time
> > falls into that part of the year?
> >
> > That would be incorrect for Europe/London, for example.
> >
> HI Patrick,
> Its not that complicated... the time is separate to the timezone info,
> which will always get sent... the adjustment is only made because
> exchange needs the time in UTC. Whenever the first instance is, it
> shouldn't matter, because the timezone info is provided as well, its
> just that the Startime needs to be converted to UTC, and if the offset
> is 0, then there is no point in making that update, as the timestring
> that we send to exchange won't be any different.
Note that this is the code converting from Exchange to iCalendar 2.0.
You are talking about the iCalendar 2.0 -> Exchange direction, aren't
you?
I was talking about this if() here in particular:
if (tzid && strlen (tzid)&& (utc_offset != 0)) { // Note: TZID not specified
if it's a UTC time
g_debug("got a tzid, %s", tzid);
param = icalparameter_new_tzid (tzid);
icalproperty_add_parameter (prop, param);
}
Doesn't that have the effect that TZID is not added if utc_offset == 0,
even though the time itself is, for example, defined in Europe/London
and thus needs a TZID?
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
_______________________________________________
SyncEvolution mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution
