Hi Patrick,

On 01/27/2012 07:00 PM, Patrick Ohly wrote:
On Fr, 2012-01-27 at 14:55 +0100, Mikel Astiz wrote:
[...]
+static class VCard30Test : public RegisterSyncSourceTest {
+public:
+    VCard30Test() : RegisterSyncSourceTest("file_contact", "eds_contact") {}
[...]
+    SuperTest() : RegisterSyncSourceTest("file_calendar+todo", 
"calendar+todo") {}
Better don't register the tests. The first parameter of
RegisterSyncSourceTest() would have to be unique (say, "pbap_contact"),
but even then the test would mostly just fail because the source is not
implementing write access.

You're right. It seems I sent the patches too soon after all :-)

I'll commit my patch which removes that dead code later today.

+PbapSyncSource::Databases PbapSyncSource::getDatabases()
+{
+    Databases result;
+
+    result.push_back(Database("select database via bluetooth
address",
+                              "[obex-bt://]<bt-addr>"));
+    return result;
+}
The obex-bt:// prefix is not optional, is it? The rest of the
documentation shows it as obligatory and the code agrees.


Right, it's currently mandatory.

Cheers,
Mikel

_______________________________________________
SyncEvolution mailing list
[email protected]
http://lists.syncevolution.org/listinfo/syncevolution

Reply via email to