Hello!

Without my knowledge, the mailing list configuration was changes such
that mails from unsubscribed senders were automatically discarded. That
was unintentional. I've changed it back so that I get a chance to
approve individual posts and senders again - no need to subscribe to the
list.

After this service announcement, back to the topic - see below...

On Fri, 2013-07-19 at 14:48 +0300, Alexander Kanavin wrote:
> On 07/15/2013 10:44 AM, Valluri, Amarnath wrote:
> 
> > I am working on gtk based UI for gSSO, It is about to ready, testing is 
> > going on.
> > I guess by this weekend, i can push the functional UI.
> 
> We're still testing the UI, it almost works :) Also real-world testing 
> uncovered some other bugs in gSSO that were invisible with 
> self-contained testing.
> 
> I'm taking a one-week vacation next week, but Amarnath will continue the 
> work, and he can also help you to set up gSSO and play with the example 
> (work in progress is here, and the complete example should be only a 
> little longer:
> http://code.google.com/p/accounts-sso/source/browse/examples/google-oauth2-example.c?repo=libgsignon-glib&name=examples
>  
> ).

As a first step, I compiled accounts-sso.libgsignon-glib,
accounts-sso.gsignond and accounts-sso.gsignond-plugin-oa from
https://code.google.com/p/accounts-sso/source/checkout

I had to patch gsignond slightly to fix autotools build issues with
out-of-tree compilation. Compilation of accounts-sso.gsignond-plugin-oa
also required one tweak. Patches attached.

I'm now at the stage where files are installed. What's next?

Running gsignond-oauth2-example with (or without) gsignond running
promply segfaults (missing error handling somewhere?):

Program received signal SIGSEGV, Segmentation fault.
0x00000000008de8d0 in ?? ()
(gdb) where
#0  0x00000000008de8d0 in ?? ()
#1  0x00007ffff6874669 in g_hash_table_lookup_node (hash_return=<synthetic 
pointer>, key=0x8de8d0, 
    hash_table=0x8de410) at 
/tmp/buildd/glib2.0-2.33.12+really2.32.4/./glib/ghash.c:401
#2  g_hash_table_lookup (hash_table=hash_table@entry=0x8de410, 
key=key@entry=0x8de8d0)
    at /tmp/buildd/glib2.0-2.33.12+really2.32.4/./glib/ghash.c:1074
#3  0x00007ffff779bb47 in gsignond_dictionary_get (dict=dict@entry=0x8de410, 
key=key@entry=0x8de8d0 "megaclient")
    at 
/home/pohly/src/accounts-sso/accounts-sso.gsignond/src/common/gsignond-dictionary.c:151
#4  0x00007ffff7bd88f6 in _process_oauth2_request (self=self@entry=0x611000, 
    session_data=session_data@entry=0x893400, tokens=tokens@entry=0x8de410)
    at 
/home/pohly/src/accounts-sso/accounts-sso.gsignond-plugin-oa/src/gsignond-oauth-plugin-oauth2.c:554
#5  0x00007ffff7bd758e in gsignond_oauth_plugin_request_initial 
(plugin=0x611000, session_data=0x893400, 
    token_cache=0x8de410, mechanism=0x401870 "oauth2")
    at 
/home/pohly/src/accounts-sso/accounts-sso.gsignond-plugin-oa/src/gsignond-oauth-plugin.c:426
#6  0x00000000004013aa in main ()
    at 
/home/pohly/src/accounts-sso/accounts-sso.gsignond-plugin-oa/examples/gsignond-oauth2-example.c:153

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.

>From 97f5aa42fa9af708fec5fc12109a3aec5856a370 Mon Sep 17 00:00:00 2001
From: Patrick Ohly <[email protected]>
Date: Tue, 23 Jul 2013 13:20:02 +0200
Subject: [PATCH 1/2] autotools: remove output files of glib-mkenums

"make clean" should remove all files generate by "make all". The files
generated by glib-mkenums were not listed as files to be cleaned and
thus were not removed.

"make distcheck" probably would have caught that. Haven't checked.
---
 src/common/Makefile.am |    6 ++++--
 src/daemon/Makefile.am |    4 ++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/common/Makefile.am b/src/common/Makefile.am
index 38ac909..46e1668 100644
--- a/src/common/Makefile.am
+++ b/src/common/Makefile.am
@@ -75,5 +75,7 @@ dist_libgsignond_common_la_SOURCES = \
     gsignond-enum.h.template \
     $(NULL)
 
-CLEANFILES = 
-
+CLEANFILES = \
+    gsignond-plugin-enum-types.h \
+    gsignond-plugin-enum-types.c \
+    $(NULL)
diff --git a/src/daemon/Makefile.am b/src/daemon/Makefile.am
index a12b30a..af61924 100644
--- a/src/daemon/Makefile.am
+++ b/src/daemon/Makefile.am
@@ -79,3 +79,7 @@ install-exec-hook:
 	chmod u+s $(DESTDIR)$(bindir)/gsignond || true
 endif
 
+CLEANFILES = \
+    gsignond-identity-enum-types.h \
+    gsignond-identity-enum-types.c \
+    $(NULL)
-- 
1.7.10.4

>From 75c2a975fe1f9cf6ee6edef83c028c0df3db7fa2 Mon Sep 17 00:00:00 2001
From: Patrick Ohly <[email protected]>
Date: Tue, 23 Jul 2013 13:22:01 +0200
Subject: [PATCH 2/2] autotools: fix out-of-tree compilation

Compiling with builddir != srcdir failed because
a) glib-mkenums did not find its input files when called
   outside of the srcdir.
b) The C files using the header files did not find them
   in the builddir, because they relied on include with double
   quotes.

Fixed with explicit $(srcdir) and -I.
---
 src/common/Makefile.am |    5 +++--
 src/daemon/Makefile.am |    8 ++++++--
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/common/Makefile.am b/src/common/Makefile.am
index 46e1668..367539b 100644
--- a/src/common/Makefile.am
+++ b/src/common/Makefile.am
@@ -13,14 +13,14 @@ BUILT_SOURCES = \
 GSIGNOND_INCLUDE_DIR=$(top_srcdir)/include/gsignond
 
 gsignond-plugin-enum-types.h: gsignond-enum.h.template $(GSIGNOND_INCLUDE_DIR)/gsignond-plugin-interface.h
-	$(GLIB_MKENUMS) --template gsignond-enum.h.template \
+	$(GLIB_MKENUMS) --template $(srcdir)/gsignond-enum.h.template \
                     --fhead "#ifndef GSIGNOND_PLUGIN_ENUM_TYPES_H_\n#define GSIGNOND_PLUGIND_ENUM_TYPES_H_\n\n#include <glib-object.h>\n\nG_BEGIN_DECLS" \
                     --identifier-prefix gsignond \
                     --ftail "\nG_END_DECLS\n\n#endif\n" \
                     $(GSIGNOND_INCLUDE_DIR)/gsignond-plugin-interface.h > $@
 
 gsignond-plugin-enum-types.c: gsignond-enum.c.template $(GSIGNOND_INCLUDE_DIR)/gsignond-plugin-interface.h
-	$(GLIB_MKENUMS) --template gsignond-enum.c.template \
+	$(GLIB_MKENUMS) --template $(srcdir)/gsignond-enum.c.template \
                     --fhead "#include \"gsignond-plugin-enum-types.h\"\n" \
                     --identifier-prefix gsignond \
                     $(GSIGNOND_INCLUDE_DIR)/gsignond-plugin-interface.h > $@
@@ -30,6 +30,7 @@ libgsignond_common_la_CPPFLAGS = \
     -I$(top_builddir) \
     -I$(top_srcdir)/src \
     -I$(top_srcdir)/include \
+    -I. \
     $(GSIGNOND_CFLAGS) \
     -DGSIGNOND_PLUGINS_DIR='"$(pluginsdir)"' \
     -DGSIGNOND_EXTENSIONS_DIR='"$(extensionsdir)"' \
diff --git a/src/daemon/Makefile.am b/src/daemon/Makefile.am
index af61924..e34ed20 100644
--- a/src/daemon/Makefile.am
+++ b/src/daemon/Makefile.am
@@ -13,13 +13,13 @@ gsignond-identity-enum-types.h: $(top_srcdir)/src/common/gsignond-enum.h.templat
                     --fhead "#ifndef GSIGNOND_IDENTITY_ENUM_TYPES_H_\n#define GSIGNOND_IDENTITY_ENUM_TYPES_H_\n\n#include <glib-object.h>\n\nG_BEGIN_DECLS" \
                     --identifier-prefix gsignond \
                     --ftail "\nG_END_DECLS\n\n#endif\n" \
-                    gsignond-identity.h > $@
+                    $(srcdir)/gsignond-identity.h > $@
 
 gsignond-identity-enum-types.c: $(top_srcdir)/src/common/gsignond-enum.c.template gsignond-identity.h
 	$(GLIB_MKENUMS) --template $(top_srcdir)/src/common/gsignond-enum.c.template \
                     --fhead "#include \"gsignond-identity-enum-types.h\"\n" \
                     --identifier-prefix gsignond \
-                    gsignond-identity.h > $@
+                    $(srcdir)/gsignond-identity.h > $@
 
 gsignond_includedir = $(includedir)/gsignond
 gsignond_pubhdr = ../../include/gsignond
@@ -58,6 +58,10 @@ gsignond_SOURCES = \
     $(BUILT_SOURCES) \
     $(NULL)
 
+gsignond_CPPFLAGS = \
+    -I. \
+    $(NULL)
+
 gsignond_CFLAGS = \
     -I$(top_builddir) \
     -I$(top_srcdir)/include/ \
-- 
1.7.10.4

>From d9e97fa46b8078ee06f843c20d8260cdb5faaef2 Mon Sep 17 00:00:00 2001
From: Patrick Ohly <[email protected]>
Date: Tue, 23 Jul 2013 13:38:55 +0200
Subject: [PATCH] autotools: fix ./autogen.sh after clean checkout

After a fresh checkout or "git clean -x -d -f", ./autogen.sh failed
with an error about not having "m4". Create an empty dir if it does
not exist yet.
---
 autogen.sh |    1 +
 1 file changed, 1 insertion(+)

diff --git a/autogen.sh b/autogen.sh
index cf28890..a6df81f 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -3,6 +3,7 @@
 srcdir=`dirname $0`
 test -z "$srcdir" && srcdir=.
 
+mkdir -p m4
 gtkdocize || exit 1
 aclocal #-I m4 
 autoheader 
-- 
1.7.10.4

_______________________________________________
SyncEvolution mailing list
[email protected]
https://lists.syncevolution.org/mailman/listinfo/syncevolution

Reply via email to