Den 13. jan. 2014 15:56, skrev Patrick Ohly:
Would you prefer something like a --enable-qt5 switch? Something
explicit instead of this implicit "pick the most recent version that we
can find"?
Well, it seems a bit ugly too.
I've tried to look into things a bit more, and perhaps the existing
autotroll.m4 thing (which seems to call qmake) might still do the job
for QtContacts, at least. The main problem in that regard is that
SyncEvolution doesn't have any way to check whether any given Qt module
is available and fall back to another module if not.
With Qt5, there's no longer a "QtMobility", but a "QtPim" or something.
So, to import QtContacts with autotroll, you should now just add
"+contacts +versit" to the main "need_qt_modules" thing, I think,
instead of having special imports for mobility. There's just no way to
know that beforehand with the current approach.
But given that knowledge of the Qt version is needed for
--enable-qt-dbus (where the syncevolution-qt-dbus.pc file needs to know
that it's now Qt5DBus, not QtDBus), and for --enable-kcalextended (where
the kcalextended modules aren't known to qmake at all, only to
pkg-config), perhaps it really is best to migrate to a completely
pkg-config-based approach, instead of using autotroll.
But, of course, a pkg-config-based approach would work for Qt4 too,
since Qt4 also has full pkg-config support. Perhaps it's best to just
use pkg-config all the way, and completely remove all uses of autotroll.m4?
_______________________________________________
SyncEvolution mailing list
[email protected]
https://lists.syncevolution.org/mailman/listinfo/syncevolution
