On 16/03/2012 10:13, Massimiliano Perrone wrote:
Hi guys,
I attached my first patch in Jira to solve [1].
In your opinion, it's ok?
[1] https://issues.apache.org/jira/browse/SYNCOPE-21
Max,
your patch looks functionally fine: here are my remarks:
1. ContentLoader.java
The patch is creating a Statement after that conn was released;
moreover, you create a new Statement that is never closed.
2. core/src/test/resources/content.xml
This file is supposed to have the same diff than
core/src/main/resources/content.xml (i.e. basic data from
ACT_GE_PROPERTY table) but instead your patch includes a whole bunch of
changes: please check.
Looking forward to see your updated patch!
Cheers.
--
Francesco Chicchiriccò
Apache Cocoon PMC and Apache Syncope PPMC Member
http://people.apache.org/~ilgrosso/
