[
https://issues.apache.org/jira/browse/SYNCOPE-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247331#comment-13247331
]
Colm O hEigeartaigh commented on SYNCOPE-45:
--------------------------------------------
Thanks Fabio, I agree.
One other question - UserRequestController contains the following delete method
that uses POST:
@PreAuthorize("isAuthenticated()")
@RequestMapping(method = RequestMethod.POST, value = "/delete")
public UserRequestTO delete(@RequestBody final Long userId) throws
NotFoundException, UnauthorizedRoleException {
Is there any reason this should be POST or can it move to GET as well?
Colm.
> Make all delete operations consistent in the REST API
> -----------------------------------------------------
>
> Key: SYNCOPE-45
> URL: https://issues.apache.org/jira/browse/SYNCOPE-45
> Project: Syncope
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
>
> There is a lack of consistency in how the REST controllers handle deletion.
> For example, RoleController.delete() does not return the deleted RoleTO
> object, unlike the corresponding method in UserController. It also uses the
> HTTP delete verb instead of get as per the UserController. I suggest there
> should be consistent behaviour for delete across the controllers, in other
> words all delete functionality should use HTTP GET and return the deleted
> object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
