[ 
https://issues.apache.org/jira/browse/SYNCOPE-212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated SYNCOPE-212:
----------------------------------------

    Attachment: syncope-212.patch


Please see the attached patch for a potential solution. 

Essentially it allows the InvalidAttrValueException to take a String error 
message, and uses this instead in each of the default Validators. 

The resulting error message displayed for the EmailAddressValidator looks 
something like:

Error:{[InvalidValues [email: rrgiknsg - "rrgiknsg" is not a valid email 
address]]}

It also fixes a trivial bug in the SyncopeClientCompositeErrorException which 
always appends a comma to the error message.

Colm.
                
> Provide Validation Error message to user
> ----------------------------------------
>
>                 Key: SYNCOPE-212
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-212
>             Project: Syncope
>          Issue Type: Improvement
>          Components: console, core
>    Affects Versions: 1.0.1-incubating
>            Reporter: Jan Bernhardt
>            Assignee: Colm O hEigeartaigh
>             Fix For: 1.1.0-incubating
>
>         Attachments: syncope-212.patch
>
>
> If values are entered into a field that uses a validator, you will only get a 
> notification that your validation failed for a specific attribute. But a user 
> will get no hints, about what was wrong and how a valid value would look like.
> InvalidAttrValueException only takes an Attribute. InvalidAttrValueException 
> should also provide a method that contains a message String. By doing so a 
> user could get notified why his value is invalid and how a good example would 
> look like!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to