Bugs item #1778930, was opened at 2007-08-21 21:04
Message generated for change (Comment added) made by dooglus
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=1778930&group_id=144022

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: dooglus (dooglus)
Assigned to: Nobody/Anonymous (nobody)
Summary: tangent 'theta' waypoints change from TCB to Linear on load

Initial Comment:
If I animate a bline's tangents and look at the generated waypoints, they are 
all green (since I'm using the default TCB Smooth interpolation).

If I then save the .sif file, rename it and open the renamed file, some of the 
waypoints are now yellow.  Specifically all of the tangents' "Theta" waypoints.

Maybe it's right that these angle parameters are interpolated linearly rather 
than smoothly, I don't know, but why does it change when I reload the file, 
rather than when I first animate the tangents?

----------------------------------------------------------------------

>Comment By: dooglus (dooglus)
Date: 2007-09-21 09:59

Message:
Logged In: YES 
user_id=1546005
Originator: YES

Fixed in r692/693.

I asked darco about this.  He said:

19:14 < darco> yes I think I had to force angles to be linear now that I
think about it
19:14 < darco> because I was having trouble with my angle interpolation
19:15 < darco> so I just disabled it
19:35 < darco> For some reason the angle interpolation just wasn't
visually looking right. I didn't have time to debug the issue at the time,
as linear looked fine for our purposes at the time...

If we have trouble with angle interpolation, let's fix it, rather than
forcing angle interpolation to linear.

----------------------------------------------------------------------

Comment By: dooglus (dooglus)
Date: 2007-09-17 18:13

Message:
Logged In: YES 
user_id=1546005
Originator: YES

The interpolation type for waypoints on creation is set by the default
interpolation type in the main synfig window, so I'll leave it at that.

Previously when the default interpolation type was 'TCB', angle waypoints
would be created as 'TCB' waypoints, and converted to 'linear' waypoints
when the .sif file was saved and then loaded.

Perhaps there's a good reason for using 'linear' for angles, rather than
'TCB', but if there is, it should work before the file is saved and
re-loaded as well.

svn r693 fixes a bug I added in r692 though.  The .sif format calls TCB
waypoints "auto"...

----------------------------------------------------------------------

Comment By: dooglus (dooglus)
Date: 2007-09-17 17:51

Message:
Logged In: YES 
user_id=1546005
Originator: YES

When saving waypoints, synfig doesn't mark TCB waypoints as TCB, because
'that's the default'.  But when loading, unmarked angle waypoints are set
to linear, because 'that's the default'.

In svn r692 I changed the save code to mark angles if they're not linear,
and other types if they're not TCB.  Next I'll change the code which
creates angle waypoints to get them to default to linear interpolation.

----------------------------------------------------------------------

Comment By: dooglus (dooglus)
Date: 2007-08-21 21:20

Message:
Logged In: YES 
user_id=1546005
Originator: YES

The first time I save the file, I see the theta waypoints like this:

                <c1>
                  <animated type="angle">
                    <waypoint time="0s">
                      <angle value="-135.000000"
guid="41F37C14FF220E3B82B1609DDF72A2AE"/>
                    </waypoint>
                    <waypoint time="1s">
                      <angle value="-112.121941"
guid="FFE85657CC4FB41D0F77A836EF131B54"/>
                    </waypoint>
                  </animated>
                </c1>

if I reload and save again, I see them like this:

                <c1>
                  <animated type="angle">
                    <waypoint time="0s" before="linear" after="linear">
                      <angle value="-135.000000"/>
                    </waypoint>
                    <waypoint time="1s" before="linear" after="linear">
                      <angle value="-112.121941"/>
                    </waypoint>
                  </animated>
                </c1>

Notice that the GUID values have disappeared (why were they saved anyway? 
I hadn't done any linking at all) and the 'before' and 'after' values have
appeared.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=1778930&group_id=144022

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to