Bugs item #2502818, was opened at 2009-01-12 23:51
Message generated for change (Comment added) made by genete
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=2502818&group_id=144022

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Render Artifact
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Genete (genete)
Assigned to: Nobody/Anonymous (nobody)
Summary: Noise when refresh an imported image layer

Initial Comment:
To reproduce the bug you have to:

1) Create a new file
2) Caret Menu > Import. Select a png or jpeg image file.
3) Select the Import Image Layer in the layer list and go to the parameter 
panel.
4) Edit the gamma value and set it to be different than 1.0
4.1) (Optional) Zoom in to trigger the tiled render.
5) Press the Refresh button (curved blue arrow in the bottom right part of the 
main window) to re- render the image in the current window.

I obtain random noises on the tiles or in the whole image every time I press 
the refresh button or move the time cursor:
ORIGINAL IMAGE:
http://synfig.org/forums/download/file.php?id=235
IMAGE AFTER PRESS REFRESH BUTTON:
http://synfig.org/forums/download/file.php?id=236

Ubuntu 8.10, amd64, gcc (Ubuntu 4.3.2-1ubuntu11) 4.3.2.
See attached file for more deatils.
It seems to be associated to 64 bit systems.

----------------------------------------------------------------------

>Comment By: Genete (genete)
Date: 2009-01-13 21:40

Message:
Fixed with svn r2329

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2009-01-13 16:41

Message:
This is the offending code:

synfig::Layer_Bitmap::filter(const Color& c)const
{
        if(gamma_adjust==1.0)
                return c;
        static Color x;
        x=c;

The static Color x is unique - both threads will use the same variable. 
The workarea and the navigator panel both render at the same time, and
fight over a single 'Color x' variable, overwriting each other.

----------------------------------------------------------------------

Comment By: Genete (genete)
Date: 2009-01-13 00:01

Message:
I've tried to see why the code of the layer_bitmap.cpp fails when the
filter member funtion is called and the gamma is not 1.0. It seems that the
powf function is not correct but that's not true. I've copied the code of
color_correct.cpp that uses a Gamma object to do the gamma corrections and
the artifact still appearing. But color_correct.cpp works fine. So I
believe that it is other problem. 
rore confirmed the same bug in Debian Sid (I think she has that) in a dual
core with a amd64 system. So it seems to be 64 bits related.
If someone else can reproduce it, please let here know.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=2502818&group_id=144022

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to