----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/19/#review33 -----------------------------------------------------------
I see lots of changes in this patch that do not belong here, mostly gratuitous whitespace changes and code re-ordering. Please revert those to make the diff more readable. synfig-studio/trunk/src/gtkmm/app.cpp <http://patches.synfig.org/r/19/#comment22> gratuitous whitespace changes here synfig-studio/trunk/src/gtkmm/devicetracker.h <http://patches.synfig.org/r/19/#comment27> Delete one of these blank lines. synfig-studio/trunk/src/gtkmm/devicetracker.cpp <http://patches.synfig.org/r/19/#comment38> Please file a bug on GTKmm about which interfaces are needed for saving device information and add the link to it in a comment here. synfig-studio/trunk/src/gtkmm/devicetracker.cpp <http://patches.synfig.org/r/19/#comment28> The re-organisation of the code here and the variable renaming seems gratuitous. synfig-studio/trunk/src/synfigapp/inputdevice.h <http://patches.synfig.org/r/19/#comment29> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.h <http://patches.synfig.org/r/19/#comment30> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.h <http://patches.synfig.org/r/19/#comment31> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.h <http://patches.synfig.org/r/19/#comment32> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment33> Gratuitous whitespace changes. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment36> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment37> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment23> Ordering these alphabetically should be in a separate patch. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment24> Ordering these alphabetically should be in a separate patch. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment39> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment25> Ordering these alphabetically should be in a separate patch. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment26> Why the change from sketch to draw? This seems unrelated to the current patch and should be changed separately. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment34> Gratuitous whitespace change. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment35> Gratuitous whitespace change. - Paul On 2009-04-08 14:22:52.227570, Gerco Ballintijn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/19/ > ----------------------------------------------------------- > > (Updated 2009-04-08 14:22:52.227570) > > > Review request for Synfig. > > > Summary > ------- > > This a preliminary patch that adds the capability of saving and restoring the > input devices configuration (i.e., tablet configuration). > > Note: The code specifically doesn't use the GTKmm layer but uses GTK+ > directly since the GTKmm wrapper is incomplete. > > There are a couple of I don't like about the patch, but first I await your > comments... > > > Diffs > ----- > > synfig-studio/trunk/src/gtkmm/app.cpp 2357 > synfig-studio/trunk/src/gtkmm/devicetracker.h 2357 > synfig-studio/trunk/src/gtkmm/devicetracker.cpp 2357 > synfig-studio/trunk/src/synfigapp/inputdevice.h 2357 > synfig-studio/trunk/src/synfigapp/inputdevice.cpp 2357 > > Diff: http://patches.synfig.org/r/19/diff > > > Testing > ------- > > > Thanks, > > Gerco > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
