----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/19/#review34 -----------------------------------------------------------
Patch looks good, except for a few remaining comments from the previous version and adding copyright info and adding your name to AUTHORS. You might also want to add doxygen comments for the new public functions. I assume it compiles and you've tested it? Please mention that in the testing done section. synfig-studio/trunk/src/gtkmm/devicetracker.cpp <http://patches.synfig.org/r/19/#comment44> You have added a fair bit of code, please add your copyright here like this: Copyright 2009 Gerco Ballintijn Please also add yourself to the AUTHORS file. You are already in about.cpp so that doesn't need changing. synfig-studio/trunk/src/gtkmm/devicetracker.cpp <http://patches.synfig.org/r/19/#comment41> Please file a bug on GTKmm asking for the required features to be added and add a comment and link about it here. synfig-studio/trunk/src/gtkmm/devicetracker.cpp <http://patches.synfig.org/r/19/#comment43> Should this comment be changed too? synfig-studio/trunk/src/gtkmm/devicetracker.cpp <http://patches.synfig.org/r/19/#comment42> Whitespace removal, please undo this. synfig-studio/trunk/src/synfigapp/inputdevice.cpp <http://patches.synfig.org/r/19/#comment40> This change belongs in a separate patch since it has nothing to do with device settings saving. - Paul On 2009-04-10 10:13:52.868668, Gerco Ballintijn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/19/ > ----------------------------------------------------------- > > (Updated 2009-04-10 10:13:52.868668) > > > Review request for Synfig. > > > Summary > ------- > > This a preliminary patch that adds the capability of saving and restoring the > input devices configuration (i.e., tablet configuration). > > Note: The code specifically doesn't use the GTKmm layer but uses GTK+ > directly since the GTKmm wrapper is incomplete. > > There are a couple of I don't like about the patch, but first I await your > comments... > > > Diffs > ----- > > synfig-studio/trunk/src/gtkmm/app.cpp 2357 > synfig-studio/trunk/src/gtkmm/devicetracker.h 2357 > synfig-studio/trunk/src/gtkmm/devicetracker.cpp 2357 > synfig-studio/trunk/src/synfigapp/inputdevice.h 2357 > synfig-studio/trunk/src/synfigapp/inputdevice.cpp 2357 > > Diff: http://patches.synfig.org/r/19/diff > > > Testing > ------- > > > Thanks, > > Gerco > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
