----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/18/#review39 -----------------------------------------------------------
Some fixes needed. /synfig-core/trunk/src/synfig/valuenode.cpp <http://patches.synfig.org/r/18/#comment61> The version is wrong since 0.61.09 is already released, the next release should be 0.61.10. The comment isn't necessary either and should be the same as the comments above it, the person who commits should predict the SVN commit revision and add the right one to the comment /synfig-core/trunk/src/synfig/valuenode_pow.h <http://patches.synfig.org/r/18/#comment74> Why the extra copyright holders? /synfig-core/trunk/src/synfig/valuenode_pow.h <http://patches.synfig.org/r/18/#comment62> Please also add yourself to AUTHORS and your copyright to the README. /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment60> Why the extra copyright holders here? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment63> Shouldn't you use INFINITY from math.h instead? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment71> I don't think these need to be exported to the user interface or the .sif file? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment70> I don't think these need to be exported to the user interface or the .sif file? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment72> I don't think these need to be exported to the user interface or the .sif file? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment75> Don't forget to update this after removing epsilon/infinite. /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment73> I don't think these need to be exported to the user interface or the .sif file? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment67> I don't think these need to be exported to the user interface or the .sif file? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment68> I don't think these need to be exported to the user interface or the .sif file? /synfig-core/trunk/src/synfig/valuenode_pow.cpp <http://patches.synfig.org/r/18/#comment69> What is this for? Why not just define epsilon = 0.00000001; in the constructor? - Paul On 2009-03-31 22:02:46.769631, nikitakit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/18/ > ----------------------------------------------------------- > > (Updated 2009-03-31 22:02:46.769631) > > > Review request for Synfig. > > > Summary > ------- > > New ValueNode type: Power (valuenode_pow): > Attributes: base, power, epsilon, infinite > Function: returns base^power > Fractional and negative powers are supported, so this ValueNode type can also > do square roots, reciprocals, etc. > > Note that I implemented this type in error-free mode. That is, the node gives > an output even if the operation is undefined. (This appears to be the > accepted standard.) The special definitions are: > 1. 0^-x is "+/- infinite" > 2. If a negative base is raised to a noninteger power, the power is rounded > (typecast) to an integer > > > Diffs > ----- > > /synfig-core/trunk/src/synfig/Makefile.am 2355 > /synfig-core/trunk/src/synfig/valuenode.cpp 2355 > /synfig-core/trunk/src/synfig/valuenode_pow.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_pow.cpp PRE-CREATION > > Diff: http://patches.synfig.org/r/18/diff > > > Testing > ------- > > Compiles & runs. All features work as planned, but the way undefined outputs > are treated may need to be revised. > > > Thanks, > > nikitakit > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list Synfig-devl@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/synfig-devl
