----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/21/#review43 -----------------------------------------------------------
Your patch seems to be missing some files. Also, do you have a .sif file to load/test these new valuenodes? /synfig-core/trunk/src/synfig/Makefile.am <http://patches.synfig.org/r/21/#comment82> Did you include valuenode_and.h in your patch? /synfig-core/trunk/src/synfig/Makefile.am <http://patches.synfig.org/r/21/#comment83> Did you include valuenode_or.h in your patch? /synfig-core/trunk/src/synfig/Makefile.am <http://patches.synfig.org/r/21/#comment84> Did you include valuenode_and.cpp in your patch? /synfig-core/trunk/src/synfig/Makefile.am <http://patches.synfig.org/r/21/#comment85> Did you include valuenode_or.cpp in your patch? - Gerco On 2009-04-11 23:10:25.025624, nikitakit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/21/ > ----------------------------------------------------------- > > (Updated 2009-04-11 23:10:25.025624) > > > Review request for Synfig. > > > Summary > ------- > > Some conversions for booleans: > > Compare > *Values: lhs,rhs,greater,equal,less > *Description: Compares lhs and rhs. The three other values can be used to > create any type of comparison. > > And,Or,Not > *Logical operators > > > Note: I broke the pretty layout of the makefile. The line breaks should be > readjusted. > > > Diffs > ----- > > /synfig-core/trunk/AUTHORS 2355 > /synfig-core/trunk/README 2355 > /synfig-core/trunk/src/synfig/Makefile.am 2355 > /synfig-core/trunk/src/synfig/valuenode.cpp 2355 > /synfig-core/trunk/src/synfig/valuenode_compare.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_compare.cpp PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_not.h PRE-CREATION > /synfig-core/trunk/src/synfig/valuenode_not.cpp PRE-CREATION > > Diff: http://patches.synfig.org/r/21/diff > > > Testing > ------- > > Compiles and runs. All the nodes appear to function properly. > > > Thanks, > > nikitakit > > ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
