----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://patches.synfig.org/r/23/#review53 -----------------------------------------------------------
Few things to fix. I recon the next/previous second buttons might be useful. Screenshot: New navigation button in the lower left corner <http://patches.synfig.org//r/23/#scomment3> Hmm, looks a bit cluttered. Screenshot: New navigation button in the lower left corner <http://patches.synfig.org//r/23/#scomment4> What about putting all the buttons on the same row, above the time sliders? synfig-studio/trunk/src/gtkmm/framedial.h <http://patches.synfig.org/r/23/#comment96> wrong filename synfig-studio/trunk/src/gtkmm/framedial.h <http://patches.synfig.org/r/23/#comment90> Please customise this synfig-studio/trunk/src/gtkmm/framedial.h <http://patches.synfig.org/r/23/#comment92> This should be $Id$ and the right svn properties set. synfig-studio/trunk/src/gtkmm/framedial.h <http://patches.synfig.org/r/23/#comment89> This is a new file, shouldn't you put your copyright here instead of dooglus/darco/etc? synfig-studio/trunk/src/gtkmm/framedial.h <http://patches.synfig.org/r/23/#comment98> This is a header file, please put the code in the .cpp file. synfig-studio/trunk/src/gtkmm/framedial.cpp <http://patches.synfig.org/r/23/#comment94> same as above synfig-studio/trunk/src/gtkmm/framedial.cpp <http://patches.synfig.org/r/23/#comment93> Same as above synfig-studio/trunk/src/gtkmm/framedial.cpp <http://patches.synfig.org/r/23/#comment95> same as above synfig-studio/trunk/src/gtkmm/framedial.cpp <http://patches.synfig.org/r/23/#comment99> Probably need to uncomment this after moving the code into METHODS below. synfig-studio/trunk/src/gtkmm/zoomdial.h <http://patches.synfig.org/r/23/#comment97> This belongs in the framedial.h header not here. - Paul On 2009-04-30 05:21:20.605360, Gerco Ballintijn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://patches.synfig.org/r/23/ > ----------------------------------------------------------- > > (Updated 2009-04-30 05:21:20.605360) > > > Review request for Synfig. > > > Summary > ------- > > Synfigstudio allows you in a canvas to go to the beginning, end, previous > frame, and next frame by using key bindings *only*. This patch adds the > necessary buttons to the canvas window. The patch does not add the previous > and next *second* buttons. These can however easily be added. > > Note: This patch is a work-in-progress. There are at least the following > points to consider: > * We might want to move (add) the play (and stop) buttons to the spot below > the navigation buttons, since there is room and they are conceptually related. > * The patch uses synfig-specific icons which prevents (make's it more > difficult?) changing them with skin changes. > * The icons used on the buttons are inconsistent with the buttons in the menu > (buttons synfigstudio is not consistent in other places either). > * We might want to add a proper menu bar and a proper button to the canvas > window, to be (more) consistent with other GUI application, but this would be > a (much) bigger change. > > > This addresses bug 2517389. > http://sf.net/support/tracker.php?aid=2517389 > > > Diffs > ----- > > synfig-studio/trunk/images/Makefile.am 2362 > synfig-studio/trunk/images/seek_begin.sif PRE-CREATION > synfig-studio/trunk/images/seek_end.sif PRE-CREATION > synfig-studio/trunk/images/seek_next_frame.sif PRE-CREATION > synfig-studio/trunk/images/seek_prev_frame.sif PRE-CREATION > synfig-studio/trunk/src/gtkmm/canvasview.cpp 2362 > synfig-studio/trunk/src/gtkmm/framedial.h PRE-CREATION > synfig-studio/trunk/src/gtkmm/framedial.cpp PRE-CREATION > synfig-studio/trunk/src/gtkmm/iconcontroller.cpp 2362 > synfig-studio/trunk/src/gtkmm/zoomdial.h 2362 > > Diff: http://patches.synfig.org/r/23/diff > > > Testing > ------- > > Compiles, runs, shows buttons, buttons work. > > > Screenshots > ----------- > > New navigation button in the lower left corner > http://patches.synfig.org/r/23/s/2/ > > > Thanks, > > Gerco > > ------------------------------------------------------------------------------ Register Now & Save for Velocity, the Web Performance & Operations Conference from O'Reilly Media. Velocity features a full day of expert-led, hands-on workshops and two days of sessions from industry leaders in dedicated Performance & Operations tracks. Use code vel09scf and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf _______________________________________________ Synfig-devl mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/synfig-devl
