Patches item #3414729, was opened at 2011-09-27 14:47
Message generated for change (Comment added) made by genete
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757418&aid=3414729&group_id=144022

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Ray Frederikson (uranus-235)
>Assigned to: Genete (genete)
Summary: Timeloop layer - incorrect for some values (fix)

Initial Comment:
Timeloop layer works incorrectly when Length parameter is set to some 
particular values.

See the attached file (timeloop-fps-issue.zip).

You see sequence of images with numbers displayed at each frame: 0, 1, 2, 3, 4, 
5, ...

It is looped with timeloop layer. And length is 16. We should expect this:

0, 1, 2, 3, ... 14, 15, 0, 1, 2, 3, ...

Instead of that we have:

0, 1, 2, 3, ... 14, 15, 16, 1, 2, 3, ...

Attached patch fixing the issue.

NOTE: Actually, if you play with this bug a little, you can see that the 
interpolation problem comes from file save/loading procedure. I.e. if you open 
sample file, change duration to 15f and then back to 16f, then everything is 
alright - you get expected sequence. But if you save and reopen file - then 
timings are messing out. Anyway, I have no time digging into XML saving 
routines and patch above fixes the problem.


----------------------------------------------------------------------

>Comment By: Genete (genete)
Date: 2011-11-11 11:04

Message:
Can't reproduce what you mention here:
NOTE: Actually, if you play with this bug a little, you can see that the
interpolation problem comes from file save/loading procedure. I.e. if you
open sample file, change duration to 15f and then back to 16f, then
everything is alright - you get expected sequence. But if you save and
reopen file - then timings are messing out. Anyway, I have no time digging
into XML saving routines and patch above fixes the problem.
Instead I get the same wrong sequence when set duration to 15f and then
back to 16f.
Anyway the patch works fine. Applied

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757418&aid=3414729&group_id=144022

------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to