Branch: refs/heads/testing
Home: https://github.com/synfig/synfig
Commit: c903f71474eb2ae4112654ea6558c790978338c9
https://github.com/synfig/synfig/commit/c903f71474eb2ae4112654ea6558c790978338c9
Author: Arya <ARYA-BHARDWAJ>
Date: 2020-05-02 (Sat, 02 May 2020)
Changed paths:
M synfig-studio/src/gui/app.cpp
M synfig-studio/src/gui/app.h
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/gui/canvasview.h
M synfig-studio/src/gui/mainwindow.cpp
M synfig-studio/src/gui/mainwindow.h
Log Message:
-----------
fix View -> Toolbar menu
Commit: af4b8333a2d176e06ca4503dc4d679cbbc5c0b02
https://github.com/synfig/synfig/commit/af4b8333a2d176e06ca4503dc4d679cbbc5c0b02
Author: ARYA-BHARDWAJ <aryabhardwaj...@gmail.com>
Date: 2020-05-02 (Sat, 02 May 2020)
Changed paths:
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/gui/canvasview.h
M synfig-studio/src/gui/mainwindow.cpp
Log Message:
-----------
toogle_displaybar() is renamed to toggle_show_toolbar()
Commit: 9ad7d22d857c42b49bde109af298c77d661a68b4
https://github.com/synfig/synfig/commit/9ad7d22d857c42b49bde109af298c77d661a68b4
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-05-03 (Sun, 03 May 2020)
Changed paths:
M synfig-studio/src/gui/app.cpp
M synfig-studio/src/gui/app.h
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/gui/canvasview.h
M synfig-studio/src/gui/mainwindow.cpp
M synfig-studio/src/gui/mainwindow.h
Log Message:
-----------
Merge PR #1386: Toolbar menu
Commit: cfe18dd9dcf053dc4da6e495e53573a49adf0606
https://github.com/synfig/synfig/commit/cfe18dd9dcf053dc4da6e495e53573a49adf0606
Author: ARYA-BHARDWAJ <aryabhardwaj...@gmail.com>
Date: 2020-05-05 (Tue, 05 May 2020)
Changed paths:
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/gui/mainwindow.cpp
Log Message:
-----------
View-Toolbar is effective for all canvases
Commit: ee9c0fe83a772a39c87ff97500781a35f842d569
https://github.com/synfig/synfig/commit/ee9c0fe83a772a39c87ff97500781a35f842d569
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-05 (Tue, 05 May 2020)
Changed paths:
M synfig-studio/src/gui/duck.h
M synfig-studio/src/gui/duckmatic.cpp
M synfig-studio/src/gui/states/state_bline.cpp
Log Message:
-----------
make first vertex selectable when creating spline
It allows now to close Spline while creating it by clicking on
first vertex, even if the tangents ducks are at same place.
This bogus duck is only used while creating spline, not editing.
fix #1281
Commit: dd22899aee08b5905db62f3099706aa4f88b1f8f
https://github.com/synfig/synfig/commit/dd22899aee08b5905db62f3099706aa4f88b1f8f
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-05 (Tue, 05 May 2020)
Changed paths:
M synfig-studio/src/gui/states/state_polygon.cpp
Log Message:
-----------
make polygon creation consistent with spline creation
Vertices are now drawn as they should: vertex color ("red/orange")
First vertex is greenish while creating, as it happens with Spline tool.
It also fixes LGTM alert
Commit: 8dc4c0642176ec57679cb5b2ac7fdb5897efef23
https://github.com/synfig/synfig/commit/8dc4c0642176ec57679cb5b2ac7fdb5897efef23
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-05-05 (Tue, 05 May 2020)
Changed paths:
M synfig-studio/src/gui/duck.h
M synfig-studio/src/gui/duckmatic.cpp
M synfig-studio/src/gui/states/state_bline.cpp
M synfig-studio/src/gui/states/state_polygon.cpp
Log Message:
-----------
Merge PR #1354: Make first vertex selectable when creating spline. Fixes
#1281.
Commit: 02747a2f8e050729c5845a62888b963118c1014d
https://github.com/synfig/synfig/commit/02747a2f8e050729c5845a62888b963118c1014d
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-05-06 (Wed, 06 May 2020)
Changed paths:
M synfig-core/src/synfig/loadcanvas.cpp
Log Message:
-----------
Don't show multiple warning messages about old canvas. Closes #1380.
Commit: 15a41673a92458a735c5945759cb51852b92b4e7
https://github.com/synfig/synfig/commit/15a41673a92458a735c5945759cb51852b92b4e7
Author: Maximilian Federle <max.fede...@googlemail.com>
Date: 2020-05-06 (Wed, 06 May 2020)
Changed paths:
M ETL/ETL/CMakeLists.txt
Log Message:
-----------
ETL: CMake: Do not install non-existing header
Commit: e8589a5975fff82ed6a13953a4704b93a5e71318
https://github.com/synfig/synfig/commit/e8589a5975fff82ed6a13953a4704b93a5e71318
Author: Maximilian Federle <max.fede...@googlemail.com>
Date: 2020-05-06 (Wed, 06 May 2020)
Changed paths:
M synfig-core/src/CMakeLists.txt
Log Message:
-----------
core: CMake: Add include & library dirs for each pkg_config module
This allows building & linking with libraries in non-standard paths.
Commit: d9723460cf84db0363f5afe7ba783f219ac710cf
https://github.com/synfig/synfig/commit/d9723460cf84db0363f5afe7ba783f219ac710cf
Author: Maximilian Federle <max.fede...@googlemail.com>
Date: 2020-05-06 (Wed, 06 May 2020)
Changed paths:
M synfig-studio/src/CMakeLists.txt
Log Message:
-----------
studio: CMake: Add include & library dirs for each pkg_config module
This allows building & linking with libraries in non-standard paths.
Commit: a724c758a5147554ade0a9dfbdbe4e0a9d6b039f
https://github.com/synfig/synfig/commit/a724c758a5147554ade0a9dfbdbe4e0a9d6b039f
Author: ice0 <konop...@gmail.com>
Date: 2020-05-07 (Thu, 07 May 2020)
Changed paths:
M ETL/ETL/CMakeLists.txt
M synfig-core/src/CMakeLists.txt
M synfig-studio/src/CMakeLists.txt
Log Message:
-----------
Merge PR #1399: Cmake fixes
Cmake fixes
Commit: 77164ff0d3b2b05476306300fbd57360ce34b478
https://github.com/synfig/synfig/commit/77164ff0d3b2b05476306300fbd57360ce34b478
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-09 (Sat, 09 May 2020)
Changed paths:
M synfig-core/src/modules/lyr_freetype/lyr_freetype.cpp
M synfig-core/src/modules/lyr_freetype/lyr_freetype.h
Log Message:
-----------
Some clean up on layer freetype (#1403)
* simplify search for font file in dirs
* print error message on console if font not found
* remove obsolete unix font path since 2007
* search for opentype fonts too
* don't use "using namespace" in header file
* move private classes away from header file
* remove unneeded #include
* fix non-initialized variable
* remove warning not-used params
Commit: eede90c6a874eced59b77b3855a5f04a033813ed
https://github.com/synfig/synfig/commit/eede90c6a874eced59b77b3855a5f04a033813ed
Author: Saurabh Chand Ramola
<31828811+saurabh-ram...@users.noreply.github.com>
Date: 2020-05-09 (Sat, 09 May 2020)
Changed paths:
M synfig-studio/plugins/lottie-exporter/common/Color.py
A synfig-studio/plugins/lottie-exporter/common/Gradient.py
M synfig-studio/plugins/lottie-exporter/common/Layer.py
M synfig-studio/plugins/lottie-exporter/common/misc.py
M synfig-studio/plugins/lottie-exporter/layers/shape.py
M synfig-studio/plugins/lottie-exporter/properties/offsetKeyframe.py
M synfig-studio/plugins/lottie-exporter/properties/shapeKeyframed.py
M synfig-studio/plugins/lottie-exporter/properties/valueKeyframe.py
M synfig-studio/plugins/lottie-exporter/settings.py
A synfig-studio/plugins/lottie-exporter/shapes/gFill.py
A synfig-studio/plugins/lottie-exporter/shapes/shape.py
A synfig-studio/plugins/lottie-exporter/synfig/rectangle.py
Log Message:
-----------
[Lottie exporter] Add support for linear gradient (#1286)
* Add support for linear gradient; Opacity of colors not working yet; Issue
raised in lottie-web repo
* Fixed rgb mistake
* Gradient layer now working with simple group layers; Need to manipulate
rectangle layer for full functionality
* Add additional height, width to handle group layer scaling
* Linear gradient working with opacity changes
* Remove redundant files
* Delete swp files
* Remove LGTM warnings
* Resolved discrepancies in spellings
Commit: 2349d947bbcceafe9dcdc782e2bb8fafb090f91f
https://github.com/synfig/synfig/commit/2349d947bbcceafe9dcdc782e2bb8fafb090f91f
Author: Aditya Abhiram <35968657+aa20...@users.noreply.github.com>
Date: 2020-05-10 (Sun, 10 May 2020)
Changed paths:
M synfig-studio/src/player/main.cpp
M synfig-studio/src/player/visualizationwindow.cpp
M synfig-studio/src/player/visualizationwindow.h
Log Message:
-----------
PR #1356: Add option to playback animation in realtime
* Modified visualizationwindow in /synfig-studio/src/player/
* Changes
* Undoing all Changes to this branch
* Rebasing with master
* Added '--benchmark' for realtime control
* Change to user help.
* Identation fixes
* Minor changes
* Resolving conflicts
* Fixing changes
Commit: 692f105841d3d3eafb53110b1a0d1f0349b668aa
https://github.com/synfig/synfig/commit/692f105841d3d3eafb53110b1a0d1f0349b668aa
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-10 (Sun, 10 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_curves.cpp
Log Message:
-----------
fix time and delta values in tooltip while dragging in Graph panel
fix #1405
Commit: b5b8239a7b7b1d896e125a2d7c4d7a70b98000e5
https://github.com/synfig/synfig/commit/b5b8239a7b7b1d896e125a2d7c4d7a70b98000e5
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-11 (Mon, 11 May 2020)
Changed paths:
M synfig-studio/src/gui/dialogs/dialog_color.cpp
M synfig-studio/src/gui/dialogs/dialog_color.h
M synfig-studio/src/gui/widgets/widget_coloredit.cpp
M synfig-studio/src/gui/widgets/widget_coloredit.h
Log Message:
-----------
Minor cleanup on color dialog (#1396)
* remove unused #include
* remove unused method and variable that didn't guard anything
* remove unused #include
* minor cleanup
* increase Color Slider minimum height
* remove useless variable
* remove unused variables
Commit: 0ca3942209ed033bec9f2c0b5a6018c63e5fbfa5
https://github.com/synfig/synfig/commit/0ca3942209ed033bec9f2c0b5a6018c63e5fbfa5
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-11 (Mon, 11 May 2020)
Changed paths:
M synfig-core/src/modules/lyr_freetype/lyr_freetype.cpp
Log Message:
-----------
fix 'font not found' in freetype layers - fix #1407
Commit: 18c174e42e82c564db6c18e2c58e50b3da05353f
https://github.com/synfig/synfig/commit/18c174e42e82c564db6c18e2c58e50b3da05353f
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-11 (Mon, 11 May 2020)
Changed paths:
M synfig-core/src/modules/lyr_freetype/lyr_freetype.cpp
Log Message:
-----------
don't waste time trying to open face of unnamed font
Commit: 5d873a34c7b9295a059ebed1007af330014140fd
https://github.com/synfig/synfig/commit/5d873a34c7b9295a059ebed1007af330014140fd
Author: ice0 <konop...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-core/src/modules/lyr_freetype/lyr_freetype.cpp
Log Message:
-----------
Merge PR #1408: Fixed 'font not found' error in FreeType layers (Fix #1407)
fix 'font not found' in freetype layers - fix #1407
Commit: 8b5e8bdaabd116eea62d545d19a653175007431e
https://github.com/synfig/synfig/commit/8b5e8bdaabd116eea62d545d19a653175007431e
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
M synfig-studio/src/gui/docks/dock_soundwave.h
M synfig-studio/src/gui/widgets/widget_soundwave.cpp
M synfig-studio/src/gui/widgets/widget_soundwave.h
M synfig-studio/src/gui/widgets/widget_time.cpp
Log Message:
-----------
Soundwave dock now uses sound layers in canvas
Commit: f3625641151be7cb9362630eecdd8a443af17039
https://github.com/synfig/synfig/commit/f3625641151be7cb9362630eecdd8a443af17039
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_soundwave.cpp
Log Message:
-----------
fix displaying sound delay
Commit: 4b4e9fc54b13421baf27883b43c6d9ca49a842b3
https://github.com/synfig/synfig/commit/4b4e9fc54b13421baf27883b43c6d9ca49a842b3
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_soundwave.cpp
Log Message:
-----------
don't reload after setting sound delay
the whole sound file is on memory... :(
Commit: 5cd05ad8f52f63132e5f9f432adb6a2a226b0e34
https://github.com/synfig/synfig/commit/5cd05ad8f52f63132e5f9f432adb6a2a226b0e34
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
Log Message:
-----------
sound panel: fix loading sound file on a saved file
relative path to synfig file, not working dir
Commit: 23151497c12471193e57f07233631aca0c26df9e
https://github.com/synfig/synfig/commit/23151497c12471193e57f07233631aca0c26df9e
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
Log Message:
-----------
fix catch exceptions
Commit: 6b5290395e6b3fdd928e32e057a55f04528cca29
https://github.com/synfig/synfig/commit/6b5290395e6b3fdd928e32e057a55f04528cca29
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
Log Message:
-----------
Sound panel now lists sound layer description too if different
from sound filename
Commit: e12b7687c5d6385447ebdc7843520c857d87300a
https://github.com/synfig/synfig/commit/e12b7687c5d6385447ebdc7843520c857d87300a
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
Log Message:
-----------
fix combobox popup weird width
Based on this https://github.com/synfig/synfig/issues/650#issuecomment-450001367
Commit: b387550e565abdeb6cf3229ed4a04b060aa3cb7e
https://github.com/synfig/synfig/commit/b387550e565abdeb6cf3229ed4a04b060aa3cb7e
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
Log Message:
-----------
always show filename in the combobox
Commit: 042bee72b8c1f92bca671fc94bae3ccac0fe4a1e
https://github.com/synfig/synfig/commit/042bee72b8c1f92bca671fc94bae3ccac0fe4a1e
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-12 (Tue, 12 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
Log Message:
-----------
ellipsize long filenames in Sound panel combobox
Commit: b6efff5fb8e3f7ee91829b24520a4cc2d6b87f32
https://github.com/synfig/synfig/commit/b6efff5fb8e3f7ee91829b24520a4cc2d6b87f32
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M synfig-studio/src/gui/docks/dock_soundwave.cpp
M synfig-studio/src/gui/docks/dock_soundwave.h
M synfig-studio/src/gui/widgets/widget_soundwave.cpp
M synfig-studio/src/gui/widgets/widget_soundwave.h
M synfig-studio/src/gui/widgets/widget_time.cpp
Log Message:
-----------
Merge PR #1370: Soundwave dock now loads sound layers from canvas
Commit: 27c7b956ea343ee71b1927e4082abd2df647eecb
https://github.com/synfig/synfig/commit/27c7b956ea343ee71b1927e4082abd2df647eecb
Author: ice0 <konop...@gmail.com>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_curves.cpp
Log Message:
-----------
Merge PR #1406: fix time and delta values in tooltip while dragging in Graph
panel
fix time and delta values in tooltip while dragging in Graph panel
Commit: f4f3c7511a4b3900e395483433e7099c30ea7aa7
https://github.com/synfig/synfig/commit/f4f3c7511a4b3900e395483433e7099c30ea7aa7
Author: Maximilian Federle <max.fede...@googlemail.com>
Date: 2020-05-13 (Wed, 13 May 2020)
Changed paths:
M .gitignore
A snap/snapcraft.yaml
Log Message:
-----------
Add support for building snap packages
Commit: fe42b8076c0d333dfab3561b59f1e50c74798b40
https://github.com/synfig/synfig/commit/fe42b8076c0d333dfab3561b59f1e50c74798b40
Author: Maximilian Federle <max.fede...@googlemail.com>
Date: 2020-05-15 (Fri, 15 May 2020)
Changed paths:
M snap/snapcraft.yaml
Log Message:
-----------
snap: Append build date & git hash to version for untagged commits
Also do not use parse-info so snapcraft does not overwrite the set
version.
Commit: 1873f44504e4d6270c245dd7b1f56df5ca799fe2
https://github.com/synfig/synfig/commit/1873f44504e4d6270c245dd7b1f56df5ca799fe2
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-15 (Fri, 15 May 2020)
Changed paths:
M synfig-studio/src/gui/app.cpp
Log Message:
-----------
Merge PR #1094: Remove unused Change Preview Quality menu item
Commit: 30a059e035768e99fd5eec7d812119f2188de2da
https://github.com/synfig/synfig/commit/30a059e035768e99fd5eec7d812119f2188de2da
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-16 (Sat, 16 May 2020)
Changed paths:
M synfig-core/src/synfig/main.cpp
Log Message:
-----------
remove unneeded path var
Commit: 6d32e5b21f53cf86bef1a420cbd34debf4aa35e9
https://github.com/synfig/synfig/commit/6d32e5b21f53cf86bef1a420cbd34debf4aa35e9
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-17 (Sun, 17 May 2020)
Changed paths:
M synfig-core/src/synfig/guid.cpp
M synfig-core/src/synfig/guid.h
M synfig-core/src/synfig/layers/layer_bitmap.cpp
M synfig-core/src/synfig/loadcanvas.cpp
M synfig-core/src/synfig/node.cpp
M synfig-core/src/synfig/node.h
M synfig-core/src/synfig/transform.cpp
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
M synfig-studio/src/gui/duck.cpp
Log Message:
-----------
hide GUID int constructor (#1404)
to avoid anybody to mess with its int parameter that could only be zero.
It fixes compiler warnings about unused parameter
Commit: 0e5aca00d20380923e6f7ffb02888ca02235a9ca
https://github.com/synfig/synfig/commit/0e5aca00d20380923e6f7ffb02888ca02235a9ca
Author: ice0 <konop...@gmail.com>
Date: 2020-05-18 (Mon, 18 May 2020)
Changed paths:
M synfig-studio/src/gui/_smach.h
M synfig-studio/src/gui/states/state_bline.cpp
M synfig-studio/src/gui/states/state_bline.h
M synfig-studio/src/gui/states/state_brush.cpp
M synfig-studio/src/gui/states/state_brush.h
M synfig-studio/src/gui/states/state_circle.cpp
M synfig-studio/src/gui/states/state_circle.h
M synfig-studio/src/gui/states/state_draw.cpp
M synfig-studio/src/gui/states/state_draw.h
M synfig-studio/src/gui/states/state_eyedrop.cpp
M synfig-studio/src/gui/states/state_eyedrop.h
M synfig-studio/src/gui/states/state_fill.cpp
M synfig-studio/src/gui/states/state_fill.h
M synfig-studio/src/gui/states/state_gradient.cpp
M synfig-studio/src/gui/states/state_gradient.h
M synfig-studio/src/gui/states/state_lasso.cpp
M synfig-studio/src/gui/states/state_lasso.h
M synfig-studio/src/gui/states/state_mirror.cpp
M synfig-studio/src/gui/states/state_mirror.h
M synfig-studio/src/gui/states/state_normal.cpp
M synfig-studio/src/gui/states/state_normal.h
M synfig-studio/src/gui/states/state_polygon.cpp
M synfig-studio/src/gui/states/state_polygon.h
M synfig-studio/src/gui/states/state_rectangle.cpp
M synfig-studio/src/gui/states/state_rectangle.h
M synfig-studio/src/gui/states/state_rotate.cpp
M synfig-studio/src/gui/states/state_rotate.h
M synfig-studio/src/gui/states/state_scale.cpp
M synfig-studio/src/gui/states/state_scale.h
M synfig-studio/src/gui/states/state_sketch.cpp
M synfig-studio/src/gui/states/state_sketch.h
M synfig-studio/src/gui/states/state_smoothmove.cpp
M synfig-studio/src/gui/states/state_smoothmove.h
M synfig-studio/src/gui/states/state_star.cpp
M synfig-studio/src/gui/states/state_star.h
M synfig-studio/src/gui/states/state_stroke.cpp
M synfig-studio/src/gui/states/state_stroke.h
M synfig-studio/src/gui/states/state_text.cpp
M synfig-studio/src/gui/states/state_text.h
M synfig-studio/src/gui/states/state_width.cpp
M synfig-studio/src/gui/states/state_width.h
M synfig-studio/src/gui/states/state_zoom.cpp
M synfig-studio/src/gui/states/state_zoom.h
Log Message:
-----------
Fixed smach (state machine) compilation on MSVC (#1423)
Commit: b680ec970f1fc28b359816e0376218277b933827
https://github.com/synfig/synfig/commit/b680ec970f1fc28b359816e0376218277b933827
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-18 (Mon, 18 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
Log Message:
-----------
Don't try to delete/move/copy zero waypoints (#1424)
If zero waypoints is selected in Timetrack and user presses Delete key,
an error message popped up as synfigapp::Action is not ready (not enough
parameters).
Commit: 69a23da7098b08bfe8991fdf26028a3f45d29466
https://github.com/synfig/synfig/commit/69a23da7098b08bfe8991fdf26028a3f45d29466
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-18 (Mon, 18 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
Log Message:
-----------
allow to select waypoints by rectangle area bottom-top where top is above
widget_timetrack. Otherwise it doesn't select anything
Commit: db75d5aaa420a9fa97b3903bfcc5735ed6bef197
https://github.com/synfig/synfig/commit/db75d5aaa420a9fa97b3903bfcc5735ed6bef197
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-18 (Mon, 18 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
Log Message:
-----------
just in case: avoid repetition of selected rows
Commit: b5e5294121bda033f2a9f86a80e7e2fdbdb3d9ef
https://github.com/synfig/synfig/commit/b5e5294121bda033f2a9f86a80e7e2fdbdb3d9ef
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-19 (Tue, 19 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_filename.cpp
Log Message:
-----------
Activate widget_filename when user chooses file via button/file dialog (#1425)
otherwise the parameter value change is only propagated when widget looses
focus or user explicitly activates (by pressing Enter/Return).
If it's a Sound layer, clicking on Play button right after choose a file (and
the edit-widget not yet loosing focus), it would play the previous audio.
Commit: 34d75aaadf70b62e5afa78cdcb74d791d57324b2
https://github.com/synfig/synfig/commit/34d75aaadf70b62e5afa78cdcb74d791d57324b2
Author: ice0 <konop...@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
Log Message:
-----------
Merge PR #1427: [Timetrack] fix in rectangle-selection bottom-top
timetrack: fix in rectangle-selection bottom-top
Commit: 217c23851aaba6978232a639aa26ad598c03c141
https://github.com/synfig/synfig/commit/217c23851aaba6978232a639aa26ad598c03c141
Author: Maximilian Federle <max.fede...@googlemail.com>
Date: 2020-05-20 (Wed, 20 May 2020)
Changed paths:
M snap/snapcraft.yaml
Log Message:
-----------
snap: Improve cleanup part
Commit: 2ab96a95adfe3fcc4e3e64485c0380a66218eedf
https://github.com/synfig/synfig/commit/2ab96a95adfe3fcc4e3e64485c0380a66218eedf
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_bline.cpp
Log Message:
-----------
Fixes glitching widthpoints. Closes #1401.
Commit: f4c8ad46fc04a7a6e39dab39f257c057c00002db
https://github.com/synfig/synfig/commit/f4c8ad46fc04a7a6e39dab39f257c057c00002db
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)
Changed paths:
M synfig-core/src/synfig/bone.cpp
M synfig-core/src/synfig/bone.h
M synfig-core/src/synfig/layers/layer_skeleton.h
M synfig-core/src/synfig/layers/layer_skeletondeformation.cpp
M synfig-core/src/synfig/layers/layer_skeletondeformation.h
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
Log Message:
-----------
remove unused #include
Commit: 05dd66478bc18bdb40716e612f9181ed92c946dc
https://github.com/synfig/synfig/commit/05dd66478bc18bdb40716e612f9181ed92c946dc
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)
Changed paths:
M synfig-core/src/synfig/bone.cpp
M synfig-core/src/synfig/bone.h
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
M synfig-core/src/synfig/valuenodes/valuenode_bone.h
Log Message:
-----------
prefer nullptr rather than 0
Commit: cdd01d8f28d7a9a665edba304051aaa6a890349a
https://github.com/synfig/synfig/commit/cdd01d8f28d7a9a665edba304051aaa6a890349a
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-05-20 (Wed, 20 May 2020)
Changed paths:
M synfig-core/src/synfig/bone.h
Log Message:
-----------
remove useless macro - use method get_string() instead
Commit: f14a5bbc64e147bd091a75c8572c6ae4b44ba742
https://github.com/synfig/synfig/commit/f14a5bbc64e147bd091a75c8572c6ae4b44ba742
Author: ice0 <konop...@gmail.com>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M .gitignore
A snap/snapcraft.yaml
Log Message:
-----------
Merge PR #1400: Add support for building snap packages
Add support for building snap packages
Commit: 5d56cdcc1ee24de17007f77bdac335e2c6da5005
https://github.com/synfig/synfig/commit/5d56cdcc1ee24de17007f77bdac335e2c6da5005
Author: ice0 <konop...@gmail.com>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M synfig-core/src/synfig/bone.cpp
M synfig-core/src/synfig/bone.h
M synfig-core/src/synfig/layers/layer_skeleton.h
M synfig-core/src/synfig/layers/layer_skeletondeformation.cpp
M synfig-core/src/synfig/layers/layer_skeletondeformation.h
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
M synfig-core/src/synfig/valuenodes/valuenode_bone.h
Log Message:
-----------
Merge PR #1435: Minor cleanup in skeleton files
Minor cleanup in skeleton files
Commit: dbd27fb50fedf129a7ea05a87297505ae13da55a
https://github.com/synfig/synfig/commit/dbd27fb50fedf129a7ea05a87297505ae13da55a
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M synfig-studio/src/gui/trees/childrentree.cpp
M synfig-studio/src/gui/trees/childrentree.h
M synfig-studio/src/gui/trees/layertree.cpp
M synfig-studio/src/gui/trees/layertree.h
Log Message:
-----------
Remove old commented-out code (gui/layertree) (#1429)
Commit: 14667ddf6f9b495b76517b276cb26f4b09aece17
https://github.com/synfig/synfig/commit/14667ddf6f9b495b76517b276cb26f4b09aece17
Author: Saurabh Chand Ramola
<31828811+saurabh-ram...@users.noreply.github.com>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M synfig-studio/plugins/lottie-exporter/common/Param.py
M synfig-studio/plugins/lottie-exporter/settings.py
Log Message:
-----------
[Lottie Exporter] Add support for aTan2 convert method (#1363)
* Commits squashed and vector angle convert method separated
* Axis problem fixed
Commit: c50ec55dfb32ab6f7336f9061d5ddd61787879a2
https://github.com/synfig/synfig/commit/c50ec55dfb32ab6f7336f9061d5ddd61787879a2
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M synfig-studio/src/gui/trees/layerparamtreestore.cpp
Log Message:
-----------
fix crashing when removing spline point too fast (#1434)
repetitive quick undo/redo after insert-item-smart could be fatal
Commit: e60a668e53cd718e910ad4172774f2672e797172
https://github.com/synfig/synfig/commit/e60a668e53cd718e910ad4172774f2672e797172
Author: ice0 <konop...@gmail.com>
Date: 2020-05-21 (Thu, 21 May 2020)
Changed paths:
M ETL/ETL/_clock_system.h
M synfig-core/src/synfig/node.cpp
M synfig-core/src/synfig/node.h
Log Message:
-----------
Cleaned clock functions. Fixed compilation on MSVC. (#1426)
Commit: ec79049a8abd482b53acb3915ad472accd24b0f9
https://github.com/synfig/synfig/commit/ec79049a8abd482b53acb3915ad472accd24b0f9
Author: Firas Hanife <firashan...@gmail.com>
Date: 2020-05-24 (Sun, 24 May 2020)
Changed paths:
M synfig-core/src/modules/mod_noise/distort.cpp
Log Message:
-----------
Animation Speed of Noise Distort Layer set to static by default
Commit: 454ac396850dd6ac58360f14039a7419460c4700
https://github.com/synfig/synfig/commit/454ac396850dd6ac58360f14039a7419460c4700
Author: Firas Hanife <firashan...@gmail.com>
Date: 2020-05-24 (Sun, 24 May 2020)
Changed paths:
M synfig-studio/build_tools/autorevision.sh
Log Message:
-----------
REVISION_ID with 7 characters instead of 6
Commit: 60bf6e30f211b093e2724d7a0f80d6981c8ad8dc
https://github.com/synfig/synfig/commit/60bf6e30f211b093e2724d7a0f80d6981c8ad8dc
Author: Firas Hanife <firashan...@gmail.com>
Date: 2020-05-24 (Sun, 24 May 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_composite.cpp
Log Message:
-----------
DashItem Offset and Length variables are not consistent when editing them
Commit: 7684be864f20b5cda39dd07833e74e78a874e6d3
https://github.com/synfig/synfig/commit/7684be864f20b5cda39dd07833e74e78a874e6d3
Author: Abhi <aa20...@gmail.com>
Date: 2020-05-24 (Sun, 24 May 2020)
Changed paths:
M synfig-core/src/synfig/rendering/surface.cpp
M synfig-core/src/synfig/rendering/surface.h
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/synfigapp/canvasinterface.cpp
M synfig-studio/src/synfigapp/canvasinterface.h
Log Message:
-----------
Removing Duplicate frames while importing an image sequence
Modified visualizationwindow in /synfig-studio/src/player/
Changes
Duplicate detection when importing sequence using Magick++; TODO: Add a bool to
ask the user for this.
Added dialogue box before importing
Fixed Indentation
Changine CMakeLists.txt
Refining code
Minor changes and identation fixes
Edited CMakeLists.txt
Edited CMakeLists.txt
Edited CMakeLists.txt
Minor optimisation
Trying to not use Magick++ for import_sequence
Fixed indentation
Modifications
Removing Magick++ from CmakeLists and fixing Indentation
Rebasing
Rebasing
Fixing rebasing issues
Removing comments
Removing duplicates while importing sequences without Magick++!
Refining the code
Working!
Indentation and dialogue fix
Commit: 6d3f75ffc8a3450587c8105a738e1b6db79f7956
https://github.com/synfig/synfig/commit/6d3f75ffc8a3450587c8105a738e1b6db79f7956
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-05-25 (Mon, 25 May 2020)
Changed paths:
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
Log Message:
-----------
quick workaround to fix crash in new timetrack (#1439)
- it happened when switching tab from a doc to another
it just avoids the crash, the cause still has to be investigated
Commit: c9e9d2f0d3021779ea351f37ddf0665a4a1d76bb
https://github.com/synfig/synfig/commit/c9e9d2f0d3021779ea351f37ddf0665a4a1d76bb
Author: Saurabh Chand Ramola
<31828811+saurabh-ram...@users.noreply.github.com>
Date: 2020-05-27 (Wed, 27 May 2020)
Changed paths:
M synfig-studio/plugins/lottie-exporter/common/Makefile.am
M synfig-studio/plugins/lottie-exporter/common/Param.py
M synfig-studio/plugins/lottie-exporter/settings.py
M synfig-studio/plugins/lottie-exporter/shapes/Makefile.am
M synfig-studio/plugins/lottie-exporter/synfig/Makefile.am
Log Message:
-----------
[Lottie Exporter] Add support for Vector Angle convert method (#1409)
* Commits squashed and rebasing error fixed
* Makefile errors fixed
Commit: 1fc89f1654264400b34ab931aeed4f6f1d15edff
https://github.com/synfig/synfig/commit/1fc89f1654264400b34ab931aeed4f6f1d15edff
Author: Keyikedalube Ndang <keyikedalubend...@protonmail.ch>
Date: 2020-05-28 (Thu, 28 May 2020)
Changed paths:
M synfig-studio/src/gui/app.cpp
Log Message:
-----------
Improved warning dialog UI
A scrollable dialog window is not intuitive because it'll be shown only
once to the user and at the most with a brief descriptive message
Moved from Gtk::ScrolledWindow to Gtk::Grid
Grid takes care of the window size automatically
Fixes #1376
Commit: 9fc95fe147179dac8f779881236d18fb76fa604c
https://github.com/synfig/synfig/commit/9fc95fe147179dac8f779881236d18fb76fa604c
Author: Anish Gulati <anish.gul...@research.iiit.ac.in>
Date: 2020-05-28 (Thu, 28 May 2020)
Changed paths:
M synfig-studio/plugins/lottie-exporter/common/Param.py
Log Message:
-----------
[Lottie exporter] Refactor radial_composite convert method (#1447)
Commit: 4c519a9539905788b66101b4b440880949733a6b
https://github.com/synfig/synfig/commit/4c519a9539905788b66101b4b440880949733a6b
Author: ice0 <konop...@gmail.com>
Date: 2020-05-28 (Thu, 28 May 2020)
Changed paths:
M synfig-studio/src/gui/app.cpp
Log Message:
-----------
Merge PR #1450: Improved warning dialog UI
Improved warning dialog UI
Commit: c51cef4a4381edc249884c2ff4fd2efdb94b69c4
https://github.com/synfig/synfig/commit/c51cef4a4381edc249884c2ff4fd2efdb94b69c4
Author: Saurabh Chand Ramola
<31828811+saurabh-ram...@users.noreply.github.com>
Date: 2020-05-30 (Sat, 30 May 2020)
Changed paths:
M synfig-studio/plugins/lottie-exporter/layers/shape.py
M synfig-studio/plugins/lottie-exporter/properties/offsetKeyframe.py
M synfig-studio/plugins/lottie-exporter/properties/shapeKeyframed.py
M synfig-studio/plugins/lottie-exporter/properties/valueKeyframe.py
M synfig-studio/plugins/lottie-exporter/settings.py
M synfig-studio/plugins/lottie-exporter/shapes/gFill.py
Log Message:
-----------
[Lottie Exporter] Add support for radial gradient layer (#1446)
* Add radial gradient layer
* Update gFill.py
Commit: 894386769881efe2702ff18b71054e6b1e9224fa
https://github.com/synfig/synfig/commit/894386769881efe2702ff18b71054e6b1e9224fa
Author: Anish Gulati <anishgulat...@gmail.com>
Date: 2020-06-01 (Mon, 01 Jun 2020)
Changed paths:
M synfig-studio/plugins/lottie-exporter/common/Param.py
M synfig-studio/plugins/lottie-exporter/common/misc.py
M synfig-studio/plugins/lottie-exporter/layers/shape_solid.py
M synfig-studio/plugins/lottie-exporter/settings.py
M synfig-studio/plugins/lottie-exporter/shapes/fill.py
M synfig-studio/plugins/lottie-exporter/shapes/gFill.py
M synfig-studio/plugins/lottie-exporter/shapes/rectangle.py
M synfig-studio/plugins/lottie-exporter/shapes/star.py
M synfig-studio/plugins/lottie-exporter/synfig/animation.py
M synfig-studio/plugins/lottie-exporter/synfig/group.py
Log Message:
-----------
[Lottie exporter] Refactor lottie modules/Added named constants (#1456)
* Refactor some modules
* Delete temp files
* Found a mistake
* Update misc.py
Commit: 1fb9c45c44311573a64dd84c986a187a665d64e2
https://github.com/synfig/synfig/commit/1fb9c45c44311573a64dd84c986a187a665d64e2
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M synfig-core/po/POTFILES.in
M synfig-studio/po/POTFILES.in
Log Message:
-----------
fix POTFILES.in
it was not updated and make "make check" fail
Commit: 068c884e8a10638cd625fbd3b42bfc6605eb2f34
https://github.com/synfig/synfig/commit/068c884e8a10638cd625fbd3b42bfc6605eb2f34
Author: ice0 <konop...@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M synfig-core/po/POTFILES.in
M synfig-studio/po/POTFILES.in
Log Message:
-----------
Merge PR #1466: fix POTFILES.in
fix POTFILES.in
Commit: c8fb721b01ce312972f1e400ed23784ed346cc64
https://github.com/synfig/synfig/commit/c8fb721b01ce312972f1e400ed23784ed346cc64
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_bline.cpp
Log Message:
-----------
fix bline_length() computation
Commit: 0f873c9a165469104676bc11c9f4521d6ad1138b
https://github.com/synfig/synfig/commit/0f873c9a165469104676bc11c9f4521d6ad1138b
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_bline.cpp
Log Message:
-----------
fix homogeneous <-> standard system position conversions
back to previous version (tag v1.3.11) and
fixed it to new index order in looped splines.
fix #1431
Bad commit was a90d014c56f0cbee21c2ab0ef68936b9e84c49b1
Commit: 334b5b9b6d888ad68bf6b1f3202f581cb3a3e14d
https://github.com/synfig/synfig/commit/334b5b9b6d888ad68bf6b1f3202f581cb3a3e14d
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-06-04 (Thu, 04 Jun 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_bline.cpp
Log Message:
-----------
Fix Incorrect position of Widthpoints on Homogenous Advanced Outline. Closes
#1431.
Commit: 4f1e92f74cb2862ae83fba73d8b35ea669fa264a
https://github.com/synfig/synfig/commit/4f1e92f74cb2862ae83fba73d8b35ea669fa264a
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-06-05 (Fri, 05 Jun 2020)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedescblinelink.cpp
Log Message:
-----------
Fix #1467: "Link to Spline" places vertex into wrong position when Spline is
looped (#1468)
Commit: 18e6acbf8682e7b4b7f2b3c10fbf9f7e9e6a3324
https://github.com/synfig/synfig/commit/18e6acbf8682e7b4b7f2b3c10fbf9f7e9e6a3324
Author: AnishGG <anish.gul...@research.iiit.ac.in>
Date: 2020-06-06 (Sat, 06 Jun 2020)
Changed paths:
M autobuild/lottie_test.sh
Log Message:
-----------
Update lottie test script
Commit: b6995dc5864f43239b4e5ac9b119222328af6af1
https://github.com/synfig/synfig/commit/b6995dc5864f43239b4e5ac9b119222328af6af1
Author: rodolforg <rodolf...@users.noreply.github.com>
Date: 2020-06-07 (Sun, 07 Jun 2020)
Changed paths:
M synfig-core/test/Makefile.am
A synfig-core/test/bline.cpp
Log Message:
-----------
Add test file for conversion between homogeneous and standard width points
(#1471)
Commit: 2515be25e158787d45b96ae252720f631b54364e
https://github.com/synfig/synfig/commit/2515be25e158787d45b96ae252720f631b54364e
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-07 (Sun, 07 Jun 2020)
Changed paths:
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_time.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_timetrack.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_timetrack.h
M synfig-studio/src/gui/cellrenderer/cellrenderer_value.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_value.h
M synfig-studio/src/gui/dialogs/dialog_preview.cpp
M synfig-studio/src/gui/dials/zoomdial.cpp
M synfig-studio/src/gui/docks/dock_history.cpp
M synfig-studio/src/gui/docks/dock_history.h
M synfig-studio/src/gui/docks/dock_layers.cpp
M synfig-studio/src/gui/docks/dock_navigator.cpp
M synfig-studio/src/gui/docks/dock_timetrack.cpp
M synfig-studio/src/gui/docks/dockbook.cpp
M synfig-studio/src/gui/docks/dockbook.h
M synfig-studio/src/gui/docks/dockdialog.cpp
A synfig-studio/src/gui/exception_guard.h
M synfig-studio/src/gui/main.cpp
M synfig-studio/src/gui/mainwindow.cpp
M synfig-studio/src/gui/preview.cpp
M synfig-studio/src/gui/selectdraghelper.h
M synfig-studio/src/gui/states/state_mirror.cpp
M synfig-studio/src/gui/trees/childrentree.cpp
M synfig-studio/src/gui/trees/keyframetree.cpp
M synfig-studio/src/gui/trees/keyframetree.h
M synfig-studio/src/gui/trees/layergrouptree.cpp
M synfig-studio/src/gui/trees/layergrouptree.h
M synfig-studio/src/gui/trees/layertree.cpp
M synfig-studio/src/gui/trees/layertree.h
M synfig-studio/src/gui/widgets/widget_canvastimeslider.cpp
M synfig-studio/src/gui/widgets/widget_color.cpp
M synfig-studio/src/gui/widgets/widget_coloredit.cpp
M synfig-studio/src/gui/widgets/widget_coloredit.h
M synfig-studio/src/gui/widgets/widget_curves.cpp
M synfig-studio/src/gui/widgets/widget_defaults.cpp
M synfig-studio/src/gui/widgets/widget_distance.cpp
M synfig-studio/src/gui/widgets/widget_distance.h
M synfig-studio/src/gui/widgets/widget_gradient.cpp
M synfig-studio/src/gui/widgets/widget_gradient.h
M synfig-studio/src/gui/widgets/widget_keyframe_list.cpp
M synfig-studio/src/gui/widgets/widget_keyframe_list.h
M synfig-studio/src/gui/widgets/widget_soundwave.cpp
M synfig-studio/src/gui/widgets/widget_time.cpp
M synfig-studio/src/gui/widgets/widget_timeslider.cpp
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
M synfig-studio/src/gui/workarea.cpp
M synfig-studio/src/gui/workarearenderer/renderer_dragbox.cpp
M synfig-studio/src/gui/workarearenderer/renderer_dragbox.h
M synfig-studio/src/gui/workarearenderer/renderer_guides.h
Log Message:
-----------
try to catch all exceptions thrown in GTK event callback handlers
This huge commit was made based on the discovery of the error reported
by Svarov-RZM in Github issue comment
https://github.com/synfig/synfig/issues/1442#issuecomment-633446649
After some investigation (reported in
https://github.com/synfig/synfig/issues/1442#issuecomment-633718069 ), the
problem is some GTK callback events call some synfigapp actions that may throw
exceptions to report
errors that would never be caught except by the main App class and main()
standard function. So, in an user perspective: Synfig Studio crashes.
For this reason, I surrounded all callback contents (60) with a try-catch
statement.
This commit avoids the crash, prints the error (or tries to) and make the
callback return the failure (if the callback can do it), propagating the error
without a sudden close of the software.
I also renamed one to follow the convention used by the rest of the code:
onKeyPressed() -> on_key_pressed_event().
Besides, I ensure every callback to be private or protected:
there's no reason to they be public.
Finally, I checked if the callbacks methods were being called by other methods
that were not signal calls. Only Workarea::on_drawing_area_event()
is used that way, but inside the same class in the methods: on_hruler_event()
and on_vruler_event(). So I think it's safe, because
I made them look to the return value and handle it.
Commit: 27f38ad306a91a41b8e121f220a27fe461d1adec
https://github.com/synfig/synfig/commit/27f38ad306a91a41b8e121f220a27fe461d1adec
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-07 (Sun, 07 Jun 2020)
Changed paths:
M synfig-studio/src/gui/exception_guard.h
Log Message:
-----------
Let Windows print useful function name
Commit: 27cd14ea7a25dbf9e3226d3f357afd8404a349a8
https://github.com/synfig/synfig/commit/27cd14ea7a25dbf9e3226d3f357afd8404a349a8
Author: ice0 <konop...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-studio/src/gui/canvasview.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_time.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_timetrack.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_timetrack.h
M synfig-studio/src/gui/cellrenderer/cellrenderer_value.cpp
M synfig-studio/src/gui/cellrenderer/cellrenderer_value.h
M synfig-studio/src/gui/dialogs/dialog_preview.cpp
M synfig-studio/src/gui/dials/zoomdial.cpp
M synfig-studio/src/gui/docks/dock_history.cpp
M synfig-studio/src/gui/docks/dock_history.h
M synfig-studio/src/gui/docks/dock_layers.cpp
M synfig-studio/src/gui/docks/dock_navigator.cpp
M synfig-studio/src/gui/docks/dock_timetrack.cpp
M synfig-studio/src/gui/docks/dockbook.cpp
M synfig-studio/src/gui/docks/dockbook.h
M synfig-studio/src/gui/docks/dockdialog.cpp
A synfig-studio/src/gui/exception_guard.h
M synfig-studio/src/gui/main.cpp
M synfig-studio/src/gui/mainwindow.cpp
M synfig-studio/src/gui/preview.cpp
M synfig-studio/src/gui/selectdraghelper.h
M synfig-studio/src/gui/states/state_mirror.cpp
M synfig-studio/src/gui/trees/childrentree.cpp
M synfig-studio/src/gui/trees/keyframetree.cpp
M synfig-studio/src/gui/trees/keyframetree.h
M synfig-studio/src/gui/trees/layergrouptree.cpp
M synfig-studio/src/gui/trees/layergrouptree.h
M synfig-studio/src/gui/trees/layertree.cpp
M synfig-studio/src/gui/trees/layertree.h
M synfig-studio/src/gui/widgets/widget_canvastimeslider.cpp
M synfig-studio/src/gui/widgets/widget_color.cpp
M synfig-studio/src/gui/widgets/widget_coloredit.cpp
M synfig-studio/src/gui/widgets/widget_coloredit.h
M synfig-studio/src/gui/widgets/widget_curves.cpp
M synfig-studio/src/gui/widgets/widget_defaults.cpp
M synfig-studio/src/gui/widgets/widget_distance.cpp
M synfig-studio/src/gui/widgets/widget_distance.h
M synfig-studio/src/gui/widgets/widget_gradient.cpp
M synfig-studio/src/gui/widgets/widget_gradient.h
M synfig-studio/src/gui/widgets/widget_keyframe_list.cpp
M synfig-studio/src/gui/widgets/widget_keyframe_list.h
M synfig-studio/src/gui/widgets/widget_soundwave.cpp
M synfig-studio/src/gui/widgets/widget_time.cpp
M synfig-studio/src/gui/widgets/widget_timeslider.cpp
M synfig-studio/src/gui/widgets/widget_timetrack.cpp
M synfig-studio/src/gui/workarea.cpp
M synfig-studio/src/gui/workarearenderer/renderer_dragbox.cpp
M synfig-studio/src/gui/workarearenderer/renderer_dragbox.h
M synfig-studio/src/gui/workarearenderer/renderer_guides.h
Log Message:
-----------
Merge PR#1475: try to catch all exceptions thrown in GTK event
callback/handlers
try to catch all exceptions thrown in GTK event callback/handlers
Commit: 6c5eec652a72b55d5b23d4e9a66f42c65901d0fb
https://github.com/synfig/synfig/commit/6c5eec652a72b55d5b23d4e9a66f42c65901d0fb
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-core/src/synfig/bone.cpp
M synfig-core/src/synfig/bone.h
M synfig-core/src/synfig/valuenodes/valuenode_bone.h
Log Message:
-----------
bones: minor cleanups of header files and #include
Commit: 93f79566b779206a8336bf2e0fab1f8f6c493866
https://github.com/synfig/synfig/commit/93f79566b779206a8336bf2e0fab1f8f6c493866
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-studio/src/gui/duckmatic.cpp
Log Message:
-----------
avoid (an improbable) crash
Commit: 1794330c196605b7795c0dbcd146fbc766012680
https://github.com/synfig/synfig/commit/1794330c196605b7795c0dbcd146fbc766012680
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-core/src/synfig/bone.cpp
Log Message:
-----------
avoid another (improbable) crash
Commit: e194811d4fe7762a747232616cd5c18b182dd12d
https://github.com/synfig/synfig/commit/e194811d4fe7762a747232616cd5c18b182dd12d
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
Log Message:
-----------
minor efficiency improvement
Commit: 0854f8a7c60fcd88f0852e76104c0157d6d5cdca
https://github.com/synfig/synfig/commit/0854f8a7c60fcd88f0852e76104c0157d6d5cdca
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
M synfig-core/src/synfig/valuenodes/valuenode_bone.h
M synfig-core/src/synfig/valuenodes/valuenode_staticlist.cpp
Log Message:
-----------
fix skeleton duplication
fix GH #453
Commit: 63bfa8545dea5e8bf0f0f01b1c77b237163c549c
https://github.com/synfig/synfig/commit/63bfa8545dea5e8bf0f0f01b1c77b237163c549c
Author: Rodolfo Ribeiro Gomes <rodolf...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-core/src/synfig/valuenodes/valuenode_staticlist.cpp
Log Message:
-----------
don't try to (re)link bones of cloned skeleton
Commit: 73ca88fbb7c4b767aecfca8bac1125a8469f6982
https://github.com/synfig/synfig/commit/73ca88fbb7c4b767aecfca8bac1125a8469f6982
Author: Konstantin Dmitriev <ksee.zelga...@gmail.com>
Date: 2020-06-08 (Mon, 08 Jun 2020)
Changed paths:
M synfig-core/src/synfig/bone.cpp
M synfig-core/src/synfig/bone.h
M synfig-core/src/synfig/valuenodes/valuenode_bone.cpp
M synfig-core/src/synfig/valuenodes/valuenode_bone.h
M synfig-core/src/synfig/valuenodes/valuenode_staticlist.cpp
M synfig-studio/src/gui/duckmatic.cpp
Log Message:
-----------
Merge PR #1438: Trying to fix skeleton copy
Compare: https://github.com/synfig/synfig/compare/251f37a0c255...73ca88fbb7c4
_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl
