Branch: refs/heads/master
  Home:   https://github.com/synfig/synfig
  Commit: 36896b9237a3a1e0e73a117b9775a738da6c7446
      
https://github.com/synfig/synfig/commit/36896b9237a3a1e0e73a117b9775a738da6c7446
  Author: rodolforg <rodolf...@users.noreply.github.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M synfig-studio/src/gui/trees/layerparamtreestore.cpp

  Log Message:
  -----------
  fix: avoid rebuild ParamTreeStore when animating a parameter (#2729)

Calling rebuild() causes two bugs:
1. Parameters panel collapses items on edit (GH#386), when we
   we have Animation Mode enabled and are editing parameter that
   wasn't previously animated.
   'Solution' seems to be to call queue_refresh()
2. Crash (or emit Gtk warning) when we animate a parameter (like
   previous case) that uses a combobox for editing (GH#2390), as
   Active Layer Name of Switch Layer or Bone Parent in Bones list
   of Skeleton Layer.
   'Solution' seems to be to call queue_rebuild()

However, when a value node is replaced (via RHandle::replace()),
it already calls Node::signal_changed() so the row is refreshed
by other signal slot.

Fix #386
Fix #2390




_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to