Branch: refs/heads/master
  Home:   https://github.com/synfig/synfig
  Commit: 4160e5d5b22fcb31e6fada2a4b2fa97061ad43b4
      
https://github.com/synfig/synfig/commit/4160e5d5b22fcb31e6fada2a4b2fa97061ad43b4
  Author: rodolforg <rodolf...@users.noreply.github.com>
  Date:   2024-09-14 (Sat, 14 Sep 2024)

  Changed paths:
    M synfig-core/src/modules/mod_imagemagick/mptr_imagemagick.cpp
    M synfig-core/src/modules/mod_imagemagick/trgt_imagemagick.cpp

  Log Message:
  -----------
  fix: change convert.exe syntax to avoid clash in Windows (#3416)

On Windows (I built with CMake) for some weird reason calling ImageMagick's 
convert calls Windows/System32/convert.exe . It's odd because my Path env var 
seems to list the mingw64 directory first, but a solution is using the 'magick' 
syntax, where you just call 'magick' to convert as per 
https://imagemagick.org/script/command-line-tools.php

The problem is widely known as per 
https://stackoverflow.com/questions/3060205/error-invalid-parameter-fom-imagemagick-convert-on-windows
 , I was getting the same 'Invalid Parameter' error

The patch uses 'magick convert' (legacy syntax), instead of 'magick' for 
compatibility with ImageMagick 6, since many distros don't have official 
packages for ImageMagick 7, despite the release being over 5 years old:

    https://packages.debian.org/search?searchon=sourcenames&keywords=imagemagick
    https://packages.fedoraproject.org/pkgs/ImageMagick/ImageMagick/
    https://packages.ubuntu.com/search?keywords=imagemagick

The reason is that v7's syntax is not fully compatible with v6 but it our 
syntax seems safe

TL;DR:
Instead of using ImageMagick with 'convert' use 'magick convert' since Win has 
another 'convert' program

Supersedes: #2951

Co-authored-by: Eduardo Hernández <coz.eduardo.hernan...@gmail.com>



To unsubscribe from these emails, change your notification settings at 
https://github.com/synfig/synfig/settings/notifications


_______________________________________________
Synfig-devl mailing list
Synfig-devl@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/synfig-devl

Reply via email to