Branch: refs/heads/master
Home: https://github.com/synfig/synfig
Commit: 2bbbf456c9b4d3e0fb43fc6ba90bc87164dcfff8
https://github.com/synfig/synfig/commit/2bbbf456c9b4d3e0fb43fc6ba90bc87164dcfff8
Author: rodolforg <[email protected]>
Date: 2025-12-16 (Tue, 16 Dec 2025)
Changed paths:
M synfig-studio/src/synfigapp/actions/valuedescconvert.cpp
Log Message:
-----------
fix: undefined behavior when user convert a value, change it, undo twice/redo
twice (#3570)
If user does the following steps, the behavior is not as it is supposed to be:
1. create a converter to a layer parameter
2. change a parameter of this converter
3. undo (the converter parameter change)
4. undo (the converter creation)
5. redo (the converter creation)
6. redo (the converter parameter change)
In the 6th step, the converter of step 5 does not change its value.
The reason is that the converter created in step 5 is a new one, not
that one of step 1. In the step 6, however, it changes the parameter
of that undone converter of step 1.
This PR avoid this issue by not creating a new converter in step 5,
but reusing the one of step 1.
To unsubscribe from these emails, change your notification settings at
https://github.com/synfig/synfig/settings/notifications
_______________________________________________
Synfig-devl mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/synfig-devl
