As I didn't get any comments on my last mail, I'm trying again, now with a patch attached :-D
I don't know if this patch is correct or if there is any reason that break is missing, but applying it fixes an assertion fail for me. systemd hits the assertion in the default branch of the switch when I have a failing timer unit and call daemon-reload. On 09/29/2010 03:23 PM, Matthias Schiffer wrote: > Hi, > the single semicolon in timer.c:433 (git ee95669) looks strange, was it > meant to be a break? > > This causes systemd to crash at the assertion on my Arch system whenever > I call daemon-reload (yes, I have some failing units, I haven't set up > everything correctly for Arch yet; I think, this is connected to > tmpwatch.timer, as I haven't installed tmpwatch). Putting a break there > fixes this. > > Matthias > > > > _______________________________________________ > systemd-devel mailing list > systemd-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/systemd-devel
From ef8bbe4d198a842b184dc52ed4b3f3a5de32690b Mon Sep 17 00:00:00 2001
From: Matthias Schiffer <mschif...@universe-factory.net>
Date: Tue, 28 Sep 2010 15:25:20 +0200
Subject: [PATCH] timer: Add missing break in switch
---
src/timer.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/timer.c b/src/timer.c
index ff94b8c..0dcaad5 100644
--- a/src/timer.c
+++ b/src/timer.c
@@ -430,7 +430,7 @@ void timer_unit_notify(Unit *u, UnitActiveState new_state) {
case TIMER_DEAD:
case TIMER_FAILED:
- ;
+ break;
default:
assert_not_reached("Unknown timer state");
--
1.7.3.1
signature.asc
Description: OpenPGP digital signature
_______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
