On Fri, 18.02.11 01:37, Miklos Vajna ([email protected]) wrote:

> On Thu, Feb 17, 2011 at 07:07:26PM +0300, Alexey Shabalin 
> <[email protected]> wrote:
> > But i have not some rule with "vgchange -a y", and have lv-disk as "LV
> > Status not available"
> 
> Here is what we use at the moment:
> 
> [Unit]
> Description=LVM activation
> DefaultDependencies=no
> After=udev-settle.service
> Before=local-fs.target
> ConditionPathExists=/sbin/vgchange

Please don't litter unit files with unnecssary ConditionPathExists=
please. .service files should be installed along side their binaries and
shipped in the same packages. So that if the .service file exists the
binary exists too, and if the binary doesn't then the .servie file
doesn't exist either.

Otherwise looks good. And yupp, e should have that in upstream LVM.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to