2011/3/16 Lennart Poettering <lenn...@poettering.net>: > On Wed, 16.03.11 11:46, fykc...@gmail.com (fykc...@gmail.com) wrote: > >> Hi all, >> >> Attachment is the patch fixing broken systemd-readahead-collect on >> mips. The patch is actually fixing the fanotify syscall on mips: >> 1. Adjust to correct syscall number. >> 2. Using directly fanotify syscall instead of >> "syscall(__NR_FANOTIFY_MARK)", which is broken on the test platform. > > Hmm, what precisely is broken? the syscall() implementation in your > glibc? If so I'd very much prefer if glibc is fixed instead. We > generally prefer fixing bugs where they are instead of taping over them > in other software. The patch fix two problems: 1. The system call number of __NR_fanotify_* is not corrrect on mips. 2. "syscall(__NR_FANOTIFY_MARK, ...)" doesn't work, I guess it was the problem of eglibc(see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=618562).
P.S. If libc could be shipped with linux kernel( just as http://lwn.net/Articles/417647/ said), things will be easier in this case. -- Regards, - cee1 _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
