On Thu, 17.03.11 16:50, Andrey Borzenkov (arvidj...@gmail.com) wrote: > > On Thu, Mar 17, 2011 at 4:43 AM, Lennart Poettering > <lenn...@poettering.net> wrote: > > On Thu, 10.03.11 00:42, Andrey Borzenkov (arvidj...@gmail.com) wrote: > >> It is not. Suggested patch attached. > > > >> From: Andrey Borzenkov <arvidj...@gmail.com> > >> Subject: [PATCH] mount: do not add dependency on network filesystem to > >> quotacheck > >> > >> This creates loop: > >> > >> fs -> quotacheck -> basic -> network -> fs > >> > >> It does not look like quota was enabled for them in /etc/init.d/netfs > >> anyway. If quota is required, it probably should be implemented as > >> per mount point unit. > > > [...] > > Anywaym uf you rework this patch to check for the usrquota/grpquota > > options I'd merge it promptly > > But it does not solve the problem of usrquota being set on a _netfs > filesystem. So either this has to be skipped completely or additional > unit provided.
Well, isn't it kind of a misconfiguration if people use "usrquota,grpquota" on a network filesystem? But I guess an explicit check for _netdev and fstype_is_network(p->fstype) can't hurt. > > Tollef grants you git access by then ;-)). Even better would be if you > > add a WANTS dep too, so that we can remove the service from being pulled > > in by default sysinit.target. > > > > You mean Wants from mount unit to quotacheck unit? Yes, from all .mount units with usrquota or grpquota to quotacheck.service. Lennart -- Lennart Poettering - Red Hat, Inc. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
