Lennart Poettering <lenn...@poettering.net> writes: > Hmm, please don't put patches after the "-- " line in your mails. I have > trouble responding to your patch mail that way, since my mailer cuts off > signatures (i.e. everything after "-- ") automatically on reply. Sorry about that, good to know for the future.
> I am not sure I understand why we need another hashmap "kept" for > this. The existing two should be fine. > > Also, why first explode the list of files matching with glob()? The > fnmatch() pattern matching looks much simpler and safer to me (and > race-free too). I had used the extra hashmap with expanded glob because it would be potentially faster with a using hashmap_get rather than find_glob moving through the hash as a linked list. I didn't think (know) about fnmatch though so that makes it pretty much a non issue. > Otherwise the patch looks fine to me. If you make these changes I am > happy to merge it. I'll get to work on implementing the rest of your suggestions, thank you very much for the feedback! -- William Douglas, Intel Open Source Technology Center _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
