On Wed, Feb 1, 2012 at 7:16 PM, Chuck Lever <chuck.le...@oracle.com> wrote: > Submit the patch you have below, then white space fixes become subsequent > clean up patches. Not only is review easier now, but if we come back to > these changes in a year to fix bugs, it's easier for us to re-learn what it > does.
I'll resubmit as two patches (one only doing indentation). Though, I'll wait a ittle while in case there is more feedback. > I'll state the question differently: When the SYSTEMD macro is defined, what > kind of tests should we run? In general, how do we confirm this is working as > expected? (There may be no good answer at the moment). In general the patch is meant to achieve two things: 1) If not using systemd, everything should work as before, even if the SYSTEMD macro is defined. 2) When using systemd, enabling rpcbind.socket should cause rpcbind to start on demand and act as if it was running all along. Anything that used to be "After=rpcbind.service" should simply be "After=rpcbind.socket" (or more generally: "After=rpcbind.target", which in turn is "After=rpcbind.socket"). Cheers, Tom _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
