On Fri, 25.05.12 16:34, shawn (shawnland...@gmail.com) wrote: > On Tue, 2012-05-22 at 13:12 +0200, Lennart Poettering wrote: > > > > Hmm, this is misleading. THis has little to do with being ready, as the > > cgroup VFS are mounted synchronously very early in PID 1 and it is > > basically very hard to run in parallel with that. > > > > So this check actually would check for something different: whether the > > system was booted with systemd at all, and whether the respective cgroup > > controller has been enabled in the kernel at all. But for the former an > > excplicit early check for sd_booted() would probably a nicer choice > > (though I must say I shiver at the idea that we add this to all our > > tools). And for the latter we should probably fix things so that the > > tool works fine even if cpuacct, memory and blkio (or any subset of them > > are not available), after all those controllers should be optional. > > > > How did you start cgtop so that you ran into this problem? > > > > Lennart > > > Amazingly enough, cgtop works just fine if we just silently ignore the > missing ones here.
Patch looks good! Applied. Lennart -- Lennart Poettering - Red Hat, Inc. _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel