On Fri, 14.09.12 11:24, Dave Reisner ([email protected]) wrote:

> > And they do have the same effect on most fs, except on sysfs. Now I am
> > wondering whether this is somthing to fix in the kernel, or to just accept.
> 
> Sure, except sysfs isn't a filesystem with a concept of streams and
> files like most other filesystems.
> 
> > Kay, Michal, you are kernel guys, what do you think about this?
> 
> fs/sysfs/file.c has this comment about sysfs_write_file():
> 
> /*
>  * <snip>
>  * There is no easy way for us to know if userspace is only doing a partial
>  * write, so we don't support them. We expect the entire buffer to come
>  * on the first write.
>  * Hint: if you're writing a value, first read the file, modify only the
>  * the value you're changing, then write entire buffer back.
>  */

Well, but this is not a partial write. THis is one write with an iovec...

Lennart

-- 
Lennart Poettering - Red Hat, Inc.
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to