On 4 February 2013 22:33, Peeters Simon <peeters.si...@gmail.com> wrote:
> 2013/2/4 Lennart Poettering <lenn...@poettering.net>: > > On Mon, 04.02.13 21:32, Simon Peeters (peeters.si...@gmail.com) wrote: > > > >> Written by Peeters Simon <peeters.si...@gmail.com>. Makefile stuff > >> and cleaned up a bit by Auke Kok <auke-jan.h....@intel.com>. > >> --- > > > > Hmm, how does this relate to this work: > > > > https://bugzilla.freedesktop.org/show_bug.cgi?id=60112 > > hmm, did not yet see this. > > > Can we merge both approaches? > > I will look at it further but my current toughts: > - the bus_parse_unit_info functions seems a good idea. > - his bus_get_uint64_property is slightly nicer than mine. > - it still uses cairo to write the plot which i think is not so nice. > (since it is overkill for writing svg) > - it seems like a more literal translation in some places. > - repeats some bugs that were in the original python version but > fixed in my version. > - it does not print bars for firmware and loader into the svg output. > - it prints more informational text on the svg. > - quiet unfortunate that these patches did not end up on the mailing list. > (and apparently the poster did not see my patches on the list either) > > so I propose I try to merge the best of both patch-sets. > > any other comments with regards to this? > I indeed did not see your patches, unfortunately. I did not think about the mailing list for that, my mistake. It is indeed a quite literal translation for the most of it. I like better your svg approach getting rid of cairo. Feel free to merge both patch-sets and to yell at me if you need some help to do so.
_______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
