2013/3/3 Kay Sievers <k...@vrfy.org>: > On Sat, Mar 2, 2013 at 10:46 PM, Michael Biebl <mbi...@gmail.com> wrote: >> since this has been on the TODO list and Kay has poked me about this, >> I went ahead and made the bash completion compatible with the new >> scheme. I.e. move the files to /usr/share/bash-completions/completions >> and make them available under the binary's name. >> I decided to split up the large completion file instead of using symlinks. >> The duplication is minimal and by splitting up, the files become much >> more readable and we only need to actually install those bits which >> are enabled via --config. > > Nice job! Commit it. > > I'm happy that we leave /etc alone with that. Packages should not > install any static data there these days. > >> For now I've hard-coded >> bashcompletiondir=$(data)/bash-completion/completions which I think is >> good enough. > > Needs to be $(datadir), I guess. Works fine for me otherwise.
Committed with this change. Thanks for catching this! Removed the item from the TODO list, too. >> That said, I can prep a follow-up patch, which makes that configurable >> and uses "pkg-config --variable=completionsdir bash-completion". >> Pretty much >> what we do for --with-dbus*dir. >> >> Let me know if you also want the latter bits. > > Sounds good to me. Ok, will have a look then. Should be mostly C&P from what is already in configure.ac. Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
