On Mon, May 06, 2013 at 12:17:45PM +0200, Lukas Nykryn wrote:
> + if (streq(suffix, "systemd/system"))
> + units = true;
Hi Lukas,
this test looks fishy. It seems that systemd-delta has a fixed set of paths,
const char prefixes[] =
"/etc\0"
"/run\0"
"/usr/local/lib\0"
"/usr/local/share\0"
"/usr/lib\0"
"/usr/share\0"
#ifdef HAVE_SPLIT_USR
"/lib\0"
#endif
;
Shouldn't at least this be changed to strictly follow the code in
systemd, with e.g. the first dir changed to $(sysconfdir)? Also,
systemd-delta should support --user mode. The list of directories will
become more complicated then. Those problems existed before your
patch, but adding a fixed test for "systemd/system" might make them
harder to fix. It seems to me that process_suffix and friends should
be extended to take the parameter which specifies if .d directories
should be honored.
Otherwise patch looks OK.
Zbyszek
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
