> Just calling service_enter_dead() does not kill any processes.
> As a result, the old process may still be running when the new one is started.

Thx for the fast response and alternative patch. I tested it in my environment as well and it works as expected killing the processes without executing the stop stuff.

> After a watchdog failure the service is in an undefined state.
> Using the normal shutdown mechanism makes no sense. Instead all processes are
> just killed and the service can try to restart.

This might depend a bit on how one sees the intention of the stop stuff. You regard ExecStop and ExecStopPost as mechanism to support stopping a service using any thinkable way.

If you use ExecStopPost to do things (cleanin up or whatever) whenever the process has been stopped, this functionality might even make sense when the process is killed due to a missed watchdog notigication.

Btw: ExecStopPost and ExecStop are called, when a process is killed by an external kill or even when it exits itsself properly. So this is somehow similar to the watchdog case, isn't it?

_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to