Hello Martin Pitt.
At first, I sorry about first patch, it is just test patch for my test PC.
It's my mistake.
As your opinion, I discussed about this issue with our firmware engineer.
He said he can not guarantee about this.
Because Product ID 300*, 270* will be expanded, And firmware have possibility
to change.
I think it have some risk...
Honestly, it's out of my control.
I'm sorry about that.
Thanks.
-Dongjun
------- Original Message -------
Sender : Martin Pitt<martin.p...@ubuntu.com>
Date : 2013-06-28 17:18 (GMT+09:00)
Title : Re: [systemd-devel] Please review the patch about support the samsung
series 2 Fn+keys.
Hello again,
장동준 [2013-06-28 8:15 +0000]:
> Please review the attached patch for the samsung series 3 Fn+F* keys(keymap
> and forced release events).
> This patch is for samsung series3 models.
Ah, I sent my reply to your first patch at the same time when you sent this
second patch.
+ENV{DMI_VENDOR}=="[sS][aA][mM][sS][uU][nN][gG]*",
ATTR{[dmi/id]product_name}=="*300E5*|*300E4*|*300E7*|*270E5*|*270E4*",
RUN+="keyboard-force-release.sh $devpath samsung-series-3"
So you already fixed the "|" and generalized these a bit. I still
wonder if it would be appropriate to use "300*|270*"?
Thanks,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
<p> </p><p> </p>
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
