On Wed, Jul 17, 2013 at 11:05:38AM -0700, Shawn wrote: > Hi! > > > On Tue, Jul 16, 2013 at 8:50 AM, Lennart Poettering > <[email protected]>wrote: > > > On Wed, 26.06.13 19:55, Zbigniew Jędrzejewski-Szmek ([email protected]) > > wrote: > > > > > A few asserts are replaced with 'return -EINVAL'. I think that > > > assert should not be used to check argument in public functions. > > > > > > Fields in struct sd_journal are rearranged to make it less > > > swiss-cheesy. > > > --- > > > Does this look sound? > > > > Yupp! Looks great! Please commit! > > > Wouldn't this be better using pthread_atfork() to avoid all the getpid() > calls? For better or worse, getpid() results are cached by glibc anyway, so current implementation should be efficient enough.
Zbyszek _______________________________________________ systemd-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/systemd-devel
