On 05/11/13 16:45, Colin Walters wrote: > On Tue, 2013-11-05 at 16:39 +0000, Colin Guthrie wrote: >> Does this not increase the danger that a "make dist" run on a machine >> without those deps installed would result in a "configure" script that >> accidentally doesn't have support for those features? > > Indeed, it does. But in theory the person rolling the tarball should > know all of the dependencies.
In theory, nobody needs regression tests, because we all write perfect code first time. :-) If you do this sort of conditionalization, I think it's worth ensuring that "make dist" fails if it would otherwise have produced an incomplete tarball. gtk-doc.make already has that check (it needs gtk-doc support *enabled* to make dist) but e.g. gcrypt probably doesn't. S _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel