git send-email is sadly still not working for me. I am pasting the
patch here and attaching it as well.

In busname_trigger_notify the last check uses IS_SET on the
busname's state but compares it to service states.

I assume that the intended logic was to check the service's
state instead.
---
 src/core/busname.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/busname.c b/src/core/busname.c
index c452656..0151ee0 100644
--- a/src/core/busname.c
+++ b/src/core/busname.c
@@ -526,7 +526,7 @@ static void busname_trigger_notify(Unit *u, Unit *other) {
                         busname_enter_listening(n);
         }

-        if (IN_SET(n->state,
+        if (IN_SET(s->state,
                    SERVICE_DEAD,
                    SERVICE_STOP, SERVICE_STOP_SIGTERM, SERVICE_STOP_SIGKILL,
                    SERVICE_STOP_POST, SERVICE_FINAL_SIGTERM,
SERVICE_FINAL_SIGKILL,
-- 
1.8.4.2
From 834438292179d8f93fd31d424579318545c1b7b9 Mon Sep 17 00:00:00 2001
From: Thomas Hindoe Paaboel Andersen <[email protected]>
Date: Wed, 4 Dec 2013 22:15:56 +0100
Subject: [PATCH] busname: check the service state instead of the busname state

In busname_trigger_notify the last check uses IS_SET on the
busname's state but compares it to service states.

I assume that the inteded logic was to check the service's
state instead.
---
 src/core/busname.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/core/busname.c b/src/core/busname.c
index c452656..0151ee0 100644
--- a/src/core/busname.c
+++ b/src/core/busname.c
@@ -526,7 +526,7 @@ static void busname_trigger_notify(Unit *u, Unit *other) {
                         busname_enter_listening(n);
         }
 
-        if (IN_SET(n->state,
+        if (IN_SET(s->state,
                    SERVICE_DEAD,
                    SERVICE_STOP, SERVICE_STOP_SIGTERM, SERVICE_STOP_SIGKILL,
                    SERVICE_STOP_POST, SERVICE_FINAL_SIGTERM, SERVICE_FINAL_SIGKILL,
-- 
1.8.4.2

_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to