On Thu, 28.11.13 09:21, David Herrmann (dh.herrm...@gmail.com) wrote:
>
> Hi
>
> On Wed, Nov 27, 2013 at 10:58 PM, Lennart Poettering
> <lenn...@poettering.net> wrote:
> > On Wed, 27.11.13 19:48, David Herrmann (dh.herrm...@gmail.com) wrote:
> >
> >> + /* skip interface, but allow callers to do that themselves */
> >> + sd_bus_message_skip(m, "s");
> >
> > This feels a bit like taping over bugs. I'd suggest adding an additional
> > parameter "const char **interface" to the function which if non-NULL is
> > updated with the interface name. If it is NULL we'd just skip th
> > interface as above...
> >
> > if (interface)
> > r = sd_bus_message_read("s", interface);
> > else
> > r = sd_bus_message_skip(m, "s");
>
> That doesn't work. The caller wants "interface" before calling this
> helper. You usually pass a different map-array depending on the
> interface, right?
>
> I can just require the caller to do the skip/read themselves?
Yeah, sounds better.
Lennart
--
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
