On Sun, 22.12.13 04:10, Zbigniew Jędrzejewski-Szmek ([email protected]) wrote:
> > const sd_bus_vtable bus_cgroup_vtable[] = {
> > + SD_BUS_PROPERTY("CPUAccounting", "b", bus_property_get_bool,
> > offsetof(CGroupContext, cpu_accounting), SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("CPUShares", "t", bus_property_get_ulong,
> > offsetof(CGroupContext, cpu_shares), SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("BlockIOAccounting", "b", bus_property_get_bool,
> > offsetof(CGroupContext, blockio_accounting), SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("BlockIOWeight", "t", bus_property_get_ulong,
> > offsetof(CGroupContext, blockio_weight), SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("BlockIODeviceWeight", "a(st)",
> > property_get_blockio_device_weight, 0, SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("BlockIOReadBandwidth", "a(st)",
> > property_get_blockio_device_bandwidths, 0, SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("BlockIOWriteBandwidth", "a(st)",
> > property_get_blockio_device_bandwidths, 0, SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("MemoryAccounting", "b", bus_property_get_bool,
> > offsetof(CGroupContext, memory_accounting), SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("MemoryLimit", "t", NULL, offsetof(CGroupContext,
> > memory_limit), SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("DevicePolicy", "s",
> > property_get_cgroup_device_policy, offsetof(CGroupContext, device_policy),
> > SD_BUS_VTABLE_PROPERTY_CONST),
> > + SD_BUS_PROPERTY("DeviceAllow", "a(ss)", property_get_device_allow,
> > 0, SD_BUS_VTABLE_PROPERTY_CONST),
> Aren't properties like "CPUShares", "MemoryAccounting", and others modifiable
> at runtime?
> Or does this _CONST mean something different?
Oh, you are right. I'll fix it.
(And yeah the const is supposed to mean that a property is constant
during the entire lifetime of the object it is on.)
https://bugs.freedesktop.org/show_bug.cgi?id=72958
Lennart
--
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
