Looks great, except for one issue:
On Sat, Jan 04, 2014 at 02:35:27AM +0100, Simon Peeters wrote:
> @@ -1865,14 +1863,11 @@ finish:
> watchdog_close(false);
>
> /* Tell the binary how often to ping */
> - snprintf(e, sizeof(e), "WATCHDOG_USEC=%llu",
> (unsigned long long) arg_shutdown_watchdog);
> - char_array_0(e);
> + asprintf(&e, "WATCHDOG_USEC=%llu", (unsigned long
> long) arg_shutdown_watchdog);
>
> - env_block = strv_append(environ, e);
> - } else {
> - env_block = strv_copy(environ);
> + strv_push(&env_block, e);
Should there be oom handling here?
Zbyszek
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
