On Sat, 15.02.14 02:38, Yuxuan Shui (yshu...@gmail.com) wrote: > Commit 5ba6985b moves the UNIT_VTABLE(u)->sigchld_event before systemd > actually reap the zombie. Which leads to service_load_pid_file accept > zombie as a valid pid.
service_load_pid_file() actually checks the validity of all PIDs before making use of them, with kill(pid, 0). Zombies actually result in ESRCH when one tries to kill them, and we will not accept the PID. Is this a real problem you encountered? Are you suggesting the kill() check doesn't work? If so, we should probably fix that rather than adding some new code... Lennart -- Lennart Poettering, Red Hat _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel