On Tue, 18.02.14 14:39, Łukasz Stelmach (l.stelm...@samsung.com) wrote:
> Do you have any plans to push the commit[1] upstream?
>
> Footnotes:
>
> [1] http://article.gmane.org/gmane.comp.sysutils.systemd.devel/15596
> [2]
> https://review.tizen.org/git/?p=platform/upstream/systemd.git;a=commitdiff;h=8445e9990936244ccb0a1023baa5abf77f3ae2c4
Both patches look pretty OK. [1] is entirely OK. Regarding [2]:
- Tabs vs. spaces
- Please do not do #defines for /dev. Also, do not hardcode the length
like this. Instead use sizeof("/dev/)-1 or so. That said, best is
actually to just use path_startswith().
Other than that looks fine...
Lennart
--
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
