On Wed, Feb 19, 2014 at 4:05 PM, Łukasz Stelmach <l.stelm...@samsung.com> wrote: > It was <2014-02-19 śro 15:52>, when Tom Gundersen wrote: >> On Wed, Feb 19, 2014 at 12:19 PM, Łukasz Stelmach >> <l.stelm...@samsung.com> wrote: >>> It was <2014-02-18 wto 03:26>, when Lennart Poettering wrote: >>>> Heya! >>>> >>>> It's release time again! It has been more than 4 months now since the >>>> last release. That's kinda emberassing, since we actually intended to go >>>> for a 2-3 week cycle... The big dbus transition took some time however. >>>> >>>> Aynway, I just finished a review of the git history, marked backportable >>>> fixes, and put together the NEWS. >>>> >>>> Kay, Zbigniew, Tom, David, Patrik, anything left to fix before I roll a >>>> release? I'd like to roll the release tomorrow (tuesday) or >>>> wednesday. Please have a closer look and test! >>> >>> --8<---------------cut here---------------start------------->8--- >>> $ git checkout b67f562c9cac44bd78b24f5aae78a1797c5d4182 >>> $ git clean -dfx >>> [...] >>> $ ./autogen.sh >>> [...] >>> $ ./configure >>> [...] >>> $ make >>> [...] >>> CC src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo >>> src/libsystemd/sd-rtnl/rtnl-message.c: In function >>> 'sd_rtnl_message_new_link': >>> src/libsystemd/sd-rtnl/rtnl-message.c:145:55: warning: declaration of >>> 'index' shadows a global declaration [-Wshadow] >>> src/libsystemd/sd-rtnl/rtnl-message.c: In function >>> 'sd_rtnl_message_new_addr': >>> src/libsystemd/sd-rtnl/rtnl-message.c:219:55: warning: declaration of >>> 'index' shadows a global declaration [-Wshadow] >>> src/libsystemd/sd-rtnl/rtnl-message.c: In function >>> 'sd_rtnl_message_append_u8': >>> src/libsystemd/sd-rtnl/rtnl-message.c:431:38: error: 'IFLA_CARRIER' >>> undeclared (first use in this function) >>> src/libsystemd/sd-rtnl/rtnl-message.c:431:38: note: each undeclared >>> identifier is reported only once for each function it appears in >>> src/libsystemd/sd-rtnl/rtnl-message.c: In function >>> 'sd_rtnl_message_append_u32': >>> src/libsystemd/sd-rtnl/rtnl-message.c:514:38: error: 'IFLA_PROMISCUITY' >>> undeclared (first use in this function) >>> src/libsystemd/sd-rtnl/rtnl-message.c:515:38: error: 'IFLA_NUM_TX_QUEUES' >>> undeclared (first use in this function) >>> src/libsystemd/sd-rtnl/rtnl-message.c:516:38: error: 'IFLA_NUM_RX_QUEUES' >>> undeclared (first use in this function) >>> make[2]: *** [src/libsystemd/sd-rtnl/libsystemd_la-rtnl-message.lo] Error 1 >>> make[1]: *** [all-recursive] Error 1 >>> make: *** [all] Error 2 >>> --8<---------------cut here---------------end--------------->8--- >>> >>> I build on Ubuntu 12.04 so there definitely something may be missing in >>> my system and I would like configure or README to tell me what am I >>> missing? >>> >>> README says I need Linux kernel >= 3.0 (>= 3.8 for Smack). NEWS mentions >>> 3.5 for /dev/kmsg. However, the undeclared symbols above seem to be >>> introduced later >>> >>> - IFLA_CARRIER - v3.9 >>> - IFLA_NUM_[RT]X_QUEUES - v3.6 >>> - IFLA_PROMISCUITY - v3.5 >> >> We probably don't want to support such old kernels much longer, but in >> this case it was easy enough to fix, so I added the defines to >> missing.h. Please test and let me know if you are still experiencing >> problems. > > src/libsystemd/sd-rtnl/test-rtnl.c needs to #include "missing.h"
Indeed. Fixed. -t _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
