2014-02-19 20:41 GMT+01:00 Kay Sievers <k...@vrfy.org>: > On Wed, Feb 19, 2014 at 8:34 PM, Peeters Simon <peeters.si...@gmail.com> > wrote: >> This weekend I switched 2 of my devices to kdbus. both running a 32bit >> system (my atom based netbook and a beaglebone black) >> >> while compiling I ran in to trouble on both devices because of missing >> division and modulo operations for uint64, both related to bloom.size >> in match.c. >> >> So my question is: is it really necessary for bloom.size to be a >> uint64? I can not imagine any use case for bloom sizes exceeding >> UINT32_MAX. >> I am not sure what the proper fix would be, I temporary fixed this by >> casting bloom.size to uint32 where needed, and this works. > > Try changing it to div_u64()? You find that in other places in the > kdbus code too. > > Send a patch please, if it works.
will do in a minute (have to get my netbook downstairs) >> I also noted that in kdbus.h (while compiling kdbus itself) ioctl.h >> does not get included resulting in missing definitions for _IO() and >> family. (at least on arm) > > Where is it defined on arm? There is an include in kdbus.h. the problem is that it is "#ifndef __KERNEL__" and I assume that __KERNEL__ gets defined when building the module. >> For the rest kdbus works great! thanks! > > Cool! > > Thanks, > Kay _______________________________________________ systemd-devel mailing list systemd-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/systemd-devel
