On Wed, 05.03.14 14:37, har...@redhat.com (har...@redhat.com) wrote:
> - return
> - a.st_dev != b.st_dev ||
> - a.st_ino != b.st_ino;
> + return (a.st_dev == b.st_dev && a.st_ino == b.st_ino);
No need for the extra "()"...
> +}
> +
> +int running_in_chroot(void) {
> + int ret = files_same("/proc/1/root", "/");
Please avoid calling functions in variable declarations. We try to avoid
that in our code, to keep variable declarations and code seperate
(initialization with a constant value is fine).
> +
> + if (ret < 0)
> + return ret;
> +
> + return (ret == 0);
No need for the extra "()"....
Otherwise looks good.
Lennart
--
Lennart Poettering, Red Hat
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
