On 05/12/2014 04:20 PM, Kay Sievers wrote:
On Mon, May 12, 2014 at 3:24 PM, Jacek Janczyk <j.janc...@samsung.com> wrote:
kernel oops when connection name (kdbus_conn.name) not set via HELLO
message but requested with attach flags KDBUS_ATTACH_CONN_NAME.
Hmm, here does it crash? Seems the code that attaches the string
checks for the string being set:
if ((mask & KDBUS_ATTACH_CONN_NAME) && conn && conn->name)
My fault. I have brought the patch from older version of the code
that we're working on. It is not relevant any more.
JJ
As conn.name is defined as "for debug purposes" I find it more
convenient to return generic name than to strip the field from
requested metadata or raise an error on request.
I prefer if we just return nothing when we miss non-essential data.
The kernel and its magic strings, which which can also just be
supplied by users like the " (deleted)" for file names, are generally
not a good idea.
Kay
_______________________________________________
systemd-devel mailing list
systemd-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
