It seems that in udevd.c synthesize_change that order of arguments in
streq_ptr is wrong, or at least it looks wrong to me.

I've attached the patch which should fix the issue.


-- 
Robert Milasan

L3 Support Engineer
SUSE Linux (http://www.suse.com)
email: [email protected]
GPG fingerprint: B6FE F4A8 0FA3 3040 3402  6FE7 2F64 167C 1909 6D1A
>From 67f470fbc1711e8199e71c30a51de5033db7b596 Mon Sep 17 00:00:00 2001
From: Robert Milasan <[email protected]>
Date: Fri, 13 Jun 2014 10:46:37 +0200
Subject: [PATCH] udevd: really check for partitions in synthesize_change

Signed-off-by: Robert Milasan <[email protected]>
---
 src/udev/udevd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/udev/udevd.c b/src/udev/udevd.c
index a45d324..aed1149 100644
--- a/src/udev/udevd.c
+++ b/src/udev/udevd.c
@@ -790,7 +790,7 @@ static int synthesize_change(struct udev_device *dev) {
                         if (!d)
                                 continue;
 
-                        if (!streq_ptr("partition", udev_device_get_devtype(d)))
+                        if (!streq_ptr(udev_device_get_devtype(d), "partition"))
                                 continue;
 
                         has_partitions = true;
@@ -820,7 +820,7 @@ static int synthesize_change(struct udev_device *dev) {
                         if (!d)
                                 continue;
 
-                        if (!streq_ptr("partition", udev_device_get_devtype(d)))
+                        if (!streq_ptr(udev_device_get_devtype(d), "partition"))
                                 continue;
 
                         log_debug("device %s closed, synthesising partition '%s' 'change'",
-- 
1.8.4.5

_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel

Reply via email to