On Thu, Jun 26, 2014 at 03:00:06PM +0300, Patrik Flykt wrote:
> On Thu, 2014-06-26 at 13:01 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> > > + *expire = 0;
> > > +
> > > + LIST_FOREACH(addresses, addr, ia->addresses) {
> > > + t = be32toh(addr->lifetime_valid);
> > > + if (*expire < t)
> > > + *expire = t;
> > > + }
> > > +
> > > + t = be32toh(ia->lifetime_t2);
> > > + if (t > *expire)
> > > + return -EINVAL;
> > > +
> > > + *expire -= t;
> > > +
> > > + return 0;
> > Please use a temporary variable so that *expire is only written to
> > when 0 is returned.
>
> And fixed as well. Any more comments or shall I send an updated version?
No comments, the rest looks great, as usual. I think you can push it.
Zbyszek
_______________________________________________
systemd-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/systemd-devel
